Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade peer dependency versions #101

Merged
merged 2 commits into from
Mar 1, 2019
+15 −15
Merged

Upgrade peer dependency versions #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c3f189
Upgrade peer dependency versions
kadamwhite Oct 30, 2018
257bf24
Bump peer deps further
mikeselander Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions packages/eslint-config-humanmade/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,23 @@
"test": "node fixtures/test-lint-config"
},
"devDependencies": {
"babel-eslint": "^7.2.3",
"chalk": "^2.3.2",
"eslint": "^4.19.1",
"eslint-config-react-app": "^2.1.0",
"eslint-plugin-flowtype": "^2.46.3",
"eslint-plugin-import": "^2.11.0",
"eslint-plugin-jsx-a11y": "^6.0.3",
"eslint-plugin-react": "^7.7.0"
"babel-eslint": "^10.0.0",
"chalk": "^2.4.1",
"eslint": "^5.10.0",
"eslint-config-react-app": "^3.0.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3.x release of eslint-config-react-app/index.js no longer includes the jsx-a11y/href-no-hash rule, not sure what release it was removed from, but the following should be removed from HM's config here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it was removed from there, I'd like to separate the upgrade from the decision of whether we should be removing that rule.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will address this in a follow-up PR on top of this PR.

"eslint-plugin-flowtype": "^3.2.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jsx-a11y": "^6.1.2",
"eslint-plugin-react": "^7.11.1"
},
"peerDependencies": {
"babel-eslint": "^7.2.3",
"eslint": "^4.19.1",
"eslint-config-react-app": "^2.1.0",
"eslint-plugin-flowtype": "^2.46.3",
"eslint-plugin-import": "^2.11.0",
"eslint-plugin-jsx-a11y": "^6.0.3",
"eslint-plugin-react": "^7.7.0"
"babel-eslint": "^10.0.0",
"eslint": "^5.10.0",
"eslint-config-react-app": "^3.0.5",
"eslint-plugin-flowtype": "^3.2.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jsx-a11y": "^6.1.2",
"eslint-plugin-react": "^7.11.1"
},
"files": [
".eslintrc",
Expand Down