Skip to content

Test Suite Improvements #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 16, 2019
Merged

Test Suite Improvements #139

merged 5 commits into from
May 16, 2019

Conversation

mikeselander
Copy link
Contributor

While debugging #81, I made a series of style fixes that keep the code a bit cleaner and easier to read.

  • Removes unused use statements
  • Moves classes from \ to use
  • Defines class variables used by the class
  • Adds @group definitions for more finite testing
  • Defines some constants that should help PHPCS work more intelligently while testing

@mikeselander mikeselander requested review from rmccue and kadamwhite May 13, 2019 22:57
rmccue
rmccue reviewed May 14, 2019
View reviewed changes
@mikeselander mikeselander merged commit f310636 into master May 16, 2019
@mikeselander mikeselander deleted the test-suite-adjustments branch May 16, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccue rmccue rmccue left review comments

@tfrommen tfrommen tfrommen approved these changes

@kadamwhite kadamwhite Awaiting requested review from kadamwhite

Assignees
No one assigned
Labels
reviewer needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeselander @rmccue @tfrommen