Register a CLI command per importer #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previouly HMCI had a single `import` command, and internally handled all arg validation and registration for each importer. It's a lot cleaner to register a CLI command per importer, so WP CLI can show the correct help, validation etc. This also simplifies the implementation significantly.
goldenapples
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
This is a big improvement as far as discoverability. The one thing I see is that the options in the help command aren't formatted correctly; is the format in get_importer_global_args() correct?
Update: never mind, that format is correct, Don't know what I was thinking of. The only thing unclear is that all of these options should be optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previouly HMCI had a single
importcommand, and internally handled all arg validation and registration for each importer. It's a lot cleaner to register a CLI command per importer, so WP CLI can show the correct help, validation etc. This also simplifies the implementation significantly.