Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check features propagation #466

Merged
merged 16 commits into from
Oct 29, 2022
Merged

Check features propagation #466

merged 16 commits into from
Oct 29, 2022

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Sep 13, 2022

This PR adds a new CI check that checks that all features that are designed to be propagated (std, runtime-benchmarks, try-runtime, etc) are actually correctly propagated.

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Oct 3, 2022

@dmitrylavrenov please provide feedback on the set of features detected and how they are propagated.

@dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov please provide feedback on the set of features detected and how they are propagated.

Sure, will do.

Copy link
Contributor

@dmitrylavrenov dmitrylavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome approach. I like it. Good exercise to get more familiar with Ruby and cargo metadata :)

@MOZGIII MOZGIII force-pushed the features-check-ci branch from b5692d9 to f07b341 Compare October 4, 2022 14:44
@MOZGIII MOZGIII force-pushed the features-check-ci branch from 954f848 to 55928f0 Compare October 4, 2022 14:48
@MOZGIII MOZGIII enabled auto-merge (squash) October 4, 2022 14:50
@MOZGIII MOZGIII enabled auto-merge (squash) October 27, 2022 15:50
@MOZGIII MOZGIII merged commit 7363f0a into master Oct 29, 2022
@MOZGIII MOZGIII deleted the features-check-ci branch October 29, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants