Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmark template with doc #470

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Conversation

henrybyhee
Copy link
Contributor

@henrybyhee henrybyhee commented Sep 15, 2022

  • Added template as well as documentation in separate .maintain folder

Succeeds 435, which was corrupted by other changes

@dmitrylavrenov
Copy link
Contributor

@henrybyhee Should we use updated template from substrate - https://github.com/humanode-network/substrate/blob/master/.maintain/frame-weight-template.hbs? They have introduced implementation WeightInfo for () for backwards compatibility and tests. Look useful.

@MOZGIII
Copy link
Contributor

MOZGIII commented Sep 19, 2022

@henrybyhee Should we use updated template from substrate - humanode-network/substrate@master/.maintain/frame-weight-template.hbs? They have introduced implementation WeightInfo for () for backwards compatibility and tests. Look useful.

We don't have backwards-compat to maintain here, so I suggest we just move forward with this without the legacy implementations.

@henrybyhee
Copy link
Contributor Author

Awesome! Will merge

@henrybyhee henrybyhee merged commit 21f4b8b into master Sep 20, 2022
@henrybyhee henrybyhee deleted the benchmark_template_with_doc branch September 20, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants