Enh: Move the widget wall entry links to a view and surround the link… #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with a div having a dedicated class
|
@luke- This PR adds these 2 HTML elements with dedicated classes allowing to style the links with CSS: And the button rendering is done in a view instead of directly into the widget, allowing to overwrite the view with a custom theme. Usage: it will allow the Clean Theme to replace the link texts with an icon. |
luke-
requested changes
Nov 17, 2024
There was a problem hiding this comment.
@marc-farre In terms of code style, I would like to avoid template files in the future that contain only a single link or/and 1-3 HTML elements.
I know that this is currently the case in various places, but I would like to eliminate this in future.
See suggestion below. What you think?
luke-
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s with a div having a dedicated class