Fix error on open old notification

Events.php

@@ -177,6 +177,14 @@ public static function onCommentAppendRules($event)
         ];
     }
 
+    public static function onContentBeforeDelete($event)
+    {
+        $reports = ReportContent::find()->where(['content_id' => $event->sender->id]);
+        foreach ($reports->each() as $report) {
+            $report->delete();
+        }
+    }
+
     private static function blockFilteredPosts(): bool
     {
         /** @var Module $module */

config.php

@@ -5,6 +5,7 @@
 use humhub\modules\admin\widgets\AdminMenu;
 use humhub\modules\comment\models\Comment;
 use humhub\modules\comment\widgets\CommentControls;
+use humhub\modules\content\models\Content;
 use humhub\modules\content\widgets\WallEntryControls;
 use humhub\modules\post\models\Post;
 use humhub\modules\reportcontent\Events;
@@ -27,5 +28,6 @@
         [Comment::class, ActiveRecord::EVENT_APPEND_RULES, [Events::class, 'onCommentAppendRules']],
         [Comment::class, ActiveRecord::EVENT_AFTER_INSERT, [Events::class, 'onCommentAfterSave']],
         [Comment::class, ActiveRecord::EVENT_AFTER_UPDATE, [Events::class, 'onCommentAfterSave']],
+        [Content::class, Content::EVENT_BEFORE_DELETE, [Events::class, 'onContentBeforeDelete']],
     ]
-];
+];

docs/CHANGELOG.md

@@ -4,6 +4,7 @@ Changelog
 1.0.4 (Unreleased)
 ----------------------
 - Enh #71: Tests for `next` version
+- Fix #72: Fix error on open old notification
 
 1.0.3 (July 10, 2023)
 ---------------------

notifications/NewReportAdmin.php

@@ -62,6 +62,10 @@ public function getUrl()
     {
         $reportedRecord = $this->getReportedRecord();
 
+        if ($reportedRecord === null) {
+            return Url::to([Yii::$app->user->isAdmin() ? '/reportcontent/admin' : '/dashboard']);
+        }
+
         if (Yii::$app->user->isGuest) {
             return $reportedRecord->getUrl();
         }
@@ -90,6 +94,10 @@ private function getReportedRecord()
         /* @var ReportContent $report */
         $report = $this->source;
 
+        if (!$report instanceof ReportContent) {
+            return null;
+        }
+
         if (empty($report->comment_id)) {
             $this->_reportedRecord = Content::findOne(['id' => $report->content_id])->getModel();
         } else {
@@ -98,4 +106,4 @@ private function getReportedRecord()
 
         return $this->_reportedRecord;
     }
-}
+}