Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js Fixes #263

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Js Fixes #263

merged 6 commits into from
Dec 3, 2024

Conversation

gevorgmansuryan
Copy link
Contributor

@gevorgmansuryan gevorgmansuryan self-assigned this Nov 26, 2024
@luke-
Copy link
Contributor

luke- commented Nov 26, 2024

@gevorgmansuryan Thanks!

@yurabakhtin Can you please review?

@luke- luke- requested a review from yurabakhtin November 26, 2024 23:37
@yurabakhtin
Copy link
Contributor

@gevorgmansuryan Thank you for the original issue fix and additional deletion fix.

But could you please review and fix why after first click the item has no the expected class item-finished? :

first-click-item-is-not-finished.mp4

compare-item-selected

@gevorgmansuryan
Copy link
Contributor Author

@yurabakhtin newly found issue is fixed and thanks for the review!

@luke- luke- merged commit 3ec964d into master Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants