-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screenshots #18
Comments
@mbumpalumpa Looks fine for me. I think we should remove the "create text file" feature for now, to avoid confusion. |
@luke- I'm not sure I understand; do you mean the name of the dropdown menu item "Create file (txt...)" or? If that's the case I can delete the parentheses and their contents. |
@mbumpalumpa We simply remove the "Create file" option. It is then only possible to view or edit files that have already been uploaded. But not to create... |
Ok, goit it. |
@luke- Is there a way that we can also allow users to view PDFs with it in the future? |
@Semir1212 I've added a new Issue for this here: https://github.com/humhub/humhub-internal/issues/197 |
@Semir1212, I'm not sure exactly about adding PDFs as they are considered binary not text files, but it's not impossible, the real issue would be being able to edit such files, I'd recommend a similar approach with xml and only allowing download and not editing. 🤔 Here's some examples of how I've implemented it using #31 as a base; So to answer your question, yes it is very possible to do this as well as create PDFs with the editor, is it really recommended or needed, probably not as all major browsers support PDF view by default. |
@ArchBlood Yes, we are planning our own PDF viewer module. @mbumpalumpa @Semir1212 Can we finalize the screenshots and texts? |
@luke- Yes, the screenshots are finished, and I’ll do the descriptions. I didn’t write them earlier because I wasn’t sure if additional features would be added. But if this is final, I’ll write the descriptions. |
@Semir1212 @luke- Ok, so this would be the new screenshot since we removed the "Create Doc" option. I just need approval for the use case scenario (same as the old one). I'll publish the description in another issue. |
Passt @mbumpalumpa |
@luke-, here is my suggestion for a use-case scenario for the module. I opted to support rolling out a new email signature as it seemed to be the only viable scenario to me, rather than some log file. But if you want, I can try to create a logical scenario where a log file would be applicable for Omrade :D. In my opinion, if someone sees HTML code, it should be enough to indicate that this isn't a word replacement, but let me know what you think.
SS1
SS2
SS3
SS4
SS5
SS6
SS7
The text was updated successfully, but these errors were encountered: