Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots #18

Closed
mbumpalumpa opened this issue Mar 22, 2024 · 11 comments
Closed

Screenshots #18

mbumpalumpa opened this issue Mar 22, 2024 · 11 comments
Assignees

Comments

@mbumpalumpa
Copy link
Contributor

mbumpalumpa commented Mar 22, 2024

@luke-, here is my suggestion for a use-case scenario for the module. I opted to support rolling out a new email signature as it seemed to be the only viable scenario to me, rather than some log file. But if you want, I can try to create a logical scenario where a log file would be applicable for Omrade :D. In my opinion, if someone sees HTML code, it should be enough to indicate that this isn't a word replacement, but let me know what you think.

SS1
screenshot1

SS2
screenshot2

SS3
screenshot3

SS4
screenshot4

SS5
screenshot5

SS6
screenshot6

SS7
screenshot7

@mbumpalumpa mbumpalumpa self-assigned this Mar 22, 2024
@luke-
Copy link
Contributor

luke- commented Mar 22, 2024

@mbumpalumpa Looks fine for me. I think we should remove the "create text file" feature for now, to avoid confusion.

@mbumpalumpa
Copy link
Contributor Author

@luke- I'm not sure I understand; do you mean the name of the dropdown menu item "Create file (txt...)" or? If that's the case I can delete the parentheses and their contents.

@luke-
Copy link
Contributor

luke- commented Mar 22, 2024

@mbumpalumpa We simply remove the "Create file" option. It is then only possible to view or edit files that have already been uploaded. But not to create...

@mbumpalumpa
Copy link
Contributor Author

Ok, goit it.

@Semir1212
Copy link

@luke- Is there a way that we can also allow users to view PDFs with it in the future?

@luke-
Copy link
Contributor

luke- commented Mar 22, 2024

@Semir1212 I've added a new Issue for this here: https://github.com/humhub/humhub-internal/issues/197

@ArchBlood
Copy link

@luke- Is there a way that we can also allow users to view PDFs with it in the future?

@Semir1212, I'm not sure exactly about adding PDFs as they are considered binary not text files, but it's not impossible, the real issue would be being able to edit such files, I'd recommend a similar approach with xml and only allowing download and not editing. 🤔

Here's some examples of how I've implemented it using #31 as a base;

Screenshot_1
Screenshot_2
Screenshot_3
Screenshot_4

So to answer your question, yes it is very possible to do this as well as create PDFs with the editor, is it really recommended or needed, probably not as all major browsers support PDF view by default.

@luke-
Copy link
Contributor

luke- commented Nov 23, 2024

@ArchBlood Yes, we are planning our own PDF viewer module.

@mbumpalumpa @Semir1212 Can we finalize the screenshots and texts?

@mbumpalumpa
Copy link
Contributor Author

@luke- Yes, the screenshots are finished, and I’ll do the descriptions. I didn’t write them earlier because I wasn’t sure if additional features would be added. But if this is final, I’ll write the descriptions.

@mbumpalumpa
Copy link
Contributor Author

@Semir1212 @luke- Ok, so this would be the new screenshot since we removed the "Create Doc" option. I just need approval for the use case scenario (same as the old one). I'll publish the description in another issue.

screenshot1
screenshot2
screenshot3
screenshot4

@Semir1212
Copy link

Passt @mbumpalumpa

mbumpalumpa added a commit that referenced this issue Nov 25, 2024
@mbumpalumpa mbumpalumpa mentioned this issue Nov 25, 2024
@luke- luke- closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants