Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets files are not refreshed after updating #21

Closed
fae7em opened this issue Nov 6, 2020 · 3 comments
Closed

Assets files are not refreshed after updating #21

fae7em opened this issue Nov 6, 2020 · 3 comments
Assignees
Labels

Comments

@fae7em
Copy link
Contributor

fae7em commented Nov 6, 2020

What steps will reproduce the problem?

If in a new version of humhub, there are some changes in assets files, the assets directory are not re-published and use the old assets files.

like humhub/humhub#4605 issue, that new feature is not working because of assets cache.

Updater should clean the assets directory, to force Yii to re-publish assets files.

@fae7em fae7em added the bug label Nov 6, 2020
@fae7em fae7em self-assigned this Nov 6, 2020
luke- added a commit that referenced this issue Nov 6, 2020
@buddh4
Copy link
Contributor

buddh4 commented Nov 6, 2020

@luke- do you think this is a problem regarding performance since flushing assets takes some time (and will delay the update process even more). Also currently active users will have to reload the page in order for new assets to be updated. Maybe related to humhub/humhub#4514

@fae7em
Copy link
Contributor Author

fae7em commented Nov 6, 2020

@luke-
Copy link
Contributor

luke- commented Nov 6, 2020

Yes, as very last step would be the safest way.

luke- added a commit that referenced this issue Nov 6, 2020
@fae7em fae7em closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants