Interest Timelines #174
Interest Timelines #174
Conversation
|
Damn, this is a nice PR. Well-played! |
lib/stream_dump.rb
Outdated
| @@ -213,6 +213,59 @@ def split_auto_follows(scope = User) | |||
| flatten(results) | |||
| end | |||
|
|
|||
| def library_progress_follows(scope = User) | |||
There was a problem hiding this comment.
Assignment Branch Condition size for library_progress_follows is too high. [26.93/25] (http://c2.com/cgi/wiki?AbcMetric)
NuckChorris
force-pushed
the
feature/media-timelines
branch
from
3a8d2f4 to
7134bae
Compare
| @@ -149,12 +149,9 @@ def activity | |||
| end | |||
|
|
|||
| def kind | |||
There was a problem hiding this comment.
what would happen if kind is nil? I don't think that is actually possible but gonna throw it out there.
There was a problem hiding this comment.
Explosions, probably. But it's something that should never happen, so I'm not terribly worried about that
app/models/library_entry.rb
Outdated
| @@ -218,6 +211,18 @@ def kind | |||
| end | |||
| end | |||
|
|
|||
| after_save if: :progress_changed? do | |||
There was a problem hiding this comment.
should this really be an after_save? Might be better to do after_commit on: :update and then wrap the statement in an if progress_changed? Only saying this because after_save deals with both create and update and you already have a create below.
NuckChorris
force-pushed
the
feature/media-timelines
branch
from
72ef773 to
ed0de4f
Compare
NuckChorris
force-pushed
the
feature/media-timelines
branch
from
ed0de4f to
a23f833
Compare
What It Is
Discussion spaces, customized to match the stuff you're interested in! Interest feeds are a combination of interest-general discussion, discussion of media in your library (excluding Dropped), and discussion of episodes you've seen or chapters you've read.
How it Works
We create a timeline for each user for each interest, have it automatically follow the interest-global feed. Then, when they update their library, we generate a MediaFollow (so they can unfollow discussion of specific series, but get it all by default). When a post is tagged with a unit, we send it to the corresponding unit feed. The interest timeline automatically follows all episodes you've seen in past.
Potential Improvements
It might get messy to follow all episode discussion. If this becomes a problem we could probably limit to the last N episodes you've seen✅ Done!The automatic MediaFollow might be better if we invert it, tracking unfollowed media instead. That way, we wouldn't try to recreate a follow you deleted✅ Done!Perhaps MediaFollow should control episode discussion too?✅ Done!What's Done
Everything!
What Needs Doing