Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/auth system #157

Merged
merged 15 commits into from
Jul 11, 2024
Merged

Feat/auth system #157

merged 15 commits into from
Jul 11, 2024

Conversation

cardosofede
Copy link
Contributor

Add the authentication system back using streamlit auth

@rapcmia
Copy link
Contributor

rapcmia commented Jul 9, 2024

PR update:

  • Initial tests commit 41d55f8933e245186af62dc2b1e065fd1cc08421
  • Setup with this PR + docker compose (BE and broker) using development image, ✅
  • Setup with this PR + BE source development branch + docker compose broker ✅
  • By default, AUTH_SYSTEM_ENABLED is false. Can only be modified via source
  • Bot orchestration is hidden when user is not logged in ✅
  • User can still run backtesting ok and controller saved on ./backend-api/bots/conf/controller/
  • After admin login:
    • Check deploy, all controllers created when not login yet are available
  • Refresh page or press c
    • Automatically logout from the dashboard portal
    • When on bot orchestration page:
      • User still able to access all pages, create and deploy config and instances , recording here
      • User will not be able to access this page when going back to hummingbot dashboard , recording here

Pending:

  • run test on new commit bcac0366eb4b43a6649f7d40b7883400311356a3

@nikspz
Copy link
Contributor

nikspz commented Jul 10, 2024

256e193

  • Cloned PRdashboard157
  • By default, AUTH_SYSTEM_ENABLED is false. Changed to True
  • Manually built docker image with AUTH_SYSTEM_ENABLED True
  • used deploy to start dashboard (docker)
  • go to localhost:8501
  1. Page refresh will lead to user Logged out

After you added connector you need to refresh the page to reflect the changes, however it will lead to user logged out

Page refresh will lead to user Logged out

  1. Minor

Actual: Logout button available only for Humingbot Dashboard tab on side pane (if you are on other tab you could not log out)

Expected:
Logout on other tabs

Logout button available only for Humingbot Dashboard tab

@rapcmia rapcmia requested review from rapcmia and nikspz July 11, 2024 11:55
@cardosofede cardosofede merged commit 7934522 into development Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants