-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/backend api security and minor fixes #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR update:
|
rapcmia
previously approved these changes
Oct 31, 2024
While closing dashboard, found out the xemm_controller is still accessible even backend-api has unathorized access on most of the controllers
Attached recording of XEMM Controller accessible when unauthorized: Screen.Recording.2024-10-31.at.4.02.22.PM.mov |
rapcmia
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is necessary to run the broker via Docker, and this version of the Backend-API via source or docker: hummingbot/backend-api#37
In this PR we should test the following things (is necessary to do a fresh install of the environment):
Auth system: change in CONFIG.py AUTH_SYSTEM_ENABLED to True by default (so you don't need to set up an env variable or set the env variable, as you want) -- > line 20 of the image.
Test that the login is working well for admin abc that is the default.
Backend API security: as you can see lines 24 and 25 were added to introduce two new env variables. By default, the user and pass are (admin, admin) for Backend API. If you run the Dashboard you should be able to use it without problems. The next thing will be:
In the last two scenarios, the dashboard should not work.