Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add download candles page #29

Merged
merged 14 commits into from
Jun 9, 2023
Merged

Conversation

cardosofede
Copy link
Contributor

  • Add docker manager
  • Add download candles page
  • Add Hummingbot set-up to run the bot with docker

@rapcmia rapcmia requested review from rapcmia and nikspz June 2, 2023 03:08
@rapcmia
Copy link
Contributor

rapcmia commented Jun 2, 2023

PR update:

  • Test local using WSL ubuntu 20.04LTS and docker desktop
  • Now supports candles downloader for binance spot/perpetual ✅
  • Search for invalid intervals, no go which is expected behavior
  • Days to download would not let go below value of 1
    • Would also not run more than 365
  • Observe dashboard logs while testing 👀
    • Test download candles
      • Give at least couple of secs or around 1-2mins to download data (depends on user network)
        image
        image
        • However when trying to clean candles folders getting Permission denied: 'data/candles/*...'
        • Run chmod 777 candles/*then clean candles folders again
          image
          image
          • all files deleted including sqlite
      • data downloader container is created under dardonacci/hummingbot:dev
        • changed to hummingbot/hummingbot:latest to check behavior, still downloading but possible there are some added features on Fede's docker image 👌🏼
      • Check scripts/data_downloader_config.yml
        • Whenever the data on candles downloader is modified, this is where it is saved 💯
    • Test Containers Management
      • Stop Container : shows excited containers 💯
        image
      • Refresh : displays current status of containers
      • Clean Containers : For this to work you have to stop the container first
        image

Pending:
While testing we notice this part where it got a conflict on container name. Tried to reproduce but unable to do so would be a WIP for QA. When this happened, we can't download any candles (different intervals) even after Clean Candles Folder button (note that all files are removed excluding sqlite)
image

@nikspz nikspz self-assigned this Jun 2, 2023
Copy link
Contributor

@fengtality fengtality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to add info to README.

I think the dashboard needs more work on the user experience - here is my experience:

I changed a few settings and clicked "Download Candles". This is what I see:

Screen Shot 2023-06-03 at 12 07 36 PM

At this point, I am a bit confused. I see that a container has been started, but I don't know what it's doing or where the candles data are being saved.

I suggest first laying out this dashboard in a Notion doc so that we know what the expected user experience should be.

@cardosofede
Copy link
Contributor Author

cardosofede commented Jun 3, 2023 via email

@cardosofede cardosofede merged commit b7a225b into main Jun 9, 2023
@cardosofede cardosofede deleted the feat/add_download_candles_page branch June 9, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants