Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty database causing the usage of undefined dashboard parameters #30

Merged

Conversation

devamin
Copy link
Contributor

@devamin devamin commented Jun 4, 2023

error screenshot :
image

stack :

2023-06-04 15:12:59.266 Uncaught app exception
Traceback (most recent call last):
  File "/Users/bkamine/miniconda3/envs/dashboard/lib/python3.9/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 565, in _run_script
    exec(code, module.__dict__)
  File "/Volumes/fs/code/hummingbot/dashboard/pages/2_🚀_Strategy_Performance.py", line 65, in <module>
    selected_exchange = st.selectbox("Select an exchange:", list(exchanges_trading_pairs.keys()))
NameError: name 'exchanges_trading_pairs' is not defined

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I was thinking is, if there is no data probably we also want to create a st.warning explaining with a message for the user, what do you think?

@@ -0,0 +1,19 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devamin I think that this configuration shouldn't be in the main branch, probably we have to exclude .vscode from the git ignore.

@cardosofede cardosofede merged commit a211633 into hummingbot:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants