Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix / revised uniswap-base support #329

Merged
merged 10 commits into from
Jul 25, 2024
Merged

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

@rapcmia rapcmia changed the title (fix) revised uniswap-base support fix / revised uniswap-base support Jun 3, 2024
@nikspz
Copy link
Contributor

nikspz commented Jun 4, 2024

c8e092b
Steps:

  1. Clone latest development branch + gwPR329
  2. connect uniswap ethereum base
  3. check balance succesfully
  4. create amm_arb strategy using uniswap_ethereum_base and binance_paper_trade
  5. start the strategy and review the error
2024-06-04 20:26:32,770 - 4059849 - hummingbot.client.hummingbot_application - INFO - start command initiated.
2024-06-04 20:26:32,850 - 4059849 - hummingbot.core.network_iterator - INFO - Network status has changed to NetworkStatus.CONNECTED. Starting networking...
2024-06-04 20:26:32,855 - 4059849 - GatewayEVMAMM - INFO - Network status has changed to NetworkStatus.CONNECTED. Starting networking...
2024-06-04 20:26:32,928 - 4059849 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/estimateGas failed. See logs for more details.
2024-06-04 20:26:32,930 - 4059849 - GatewayEVMAMM - WARNING - Error on POST https://localhost:15888/amm/estimateGas Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: No address for Uniswap Multicall Contract on chain id: 8453\n    at new UniswapMulticallProvider (/home/nikita/gwb329/node_modules/@uniswap/smart-order-router/build/main/providers/multicall-uniswap-provider.js:30:19)\n    at new AlphaRouter (/home/nikita/gwb329/node_modules/@uniswap/smart-order-router/build/main/routers/alpha-router/alpha-router.js:47:97)\n    at new Uniswap (/home/nikita/gwb329/dist/src/connectors/uniswap/uniswap.js:47:29)\n    at Uniswap.getInstance (/home/nikita/gwb329/dist/src/connectors/uniswap/uniswap.js:72:51)\n    at /home/nikita/gwb329/dist/src/services/connection-manager.js:132:51\n    at Generator.next (<anonymous>)\n    at /home/nikita/gwb329/dist/src/services/connection-manager.js:8:71\n    at new Promise (<anonymous>)\n    at __awaiter (/home/nikita/gwb329/dist/src/services/connection-manager.js:4:12)\n    at getConnector (/home/nikita/gwb329/dist/src/services/connection-manager.js:128:12)'}
2024-06-04 20:26:33,564 - 4059849 - hummingbot.connector.exchange.binance.binance_api_order_book_data_source.BinanceAPIOrderBookDataSource - INFO - Subscribed to public order book and trade channels...
2024-06-04 20:26:33,665 - 4059849 - hummingbot.core.data_type.order_book_tracker - INFO - Initialized order book for ETH-USDT. 1/1 completed.
2024-06-04 20:26:40,000 - 4059849 - hummingbot.strategy.amm_arb.amm_arb - WARNING - uniswap_ethereum_base not ready: waiting for network_transaction_fee.
2024-06-04 20:26:50,001 - 4059849 - hummingbot.strategy.amm_arb.amm_arb - WARNING - uniswap_ethereum_base not ready: waiting for network_transaction_fee.
2024-06-04 20:27:00,001 - 4059849 - hummingbot.strategy.amm_arb.amm_arb - WARNING - uniswap_ethereum_base not ready: waiting for network_transaction_fee.
2024-06-04 20:27:10,000 - 4059849 - hummingbot.strategy.amm_arb.amm_arb - WARNING - uniswap_ethereum_base not ready: waiting for network_transaction_fee.

logs_conf_amm_arb_1.log
gw329.zip

image

@rapcmia rapcmia requested a review from nikspz June 6, 2024 11:42
Copy link

@fengtality
Copy link
Contributor Author

@nikspz This PR is ready for testing. The tests still fail, but I'm working on a fix.

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Cloned gwPR329 with Client latest development
  • gateway connect uniswap_ethereum_base successfully
  • added gateway connector-tokens WETH,USDC
  • gateway balance now show WETH,USDC balance
  • created amm_arb strategy using uniswap ethereum base
  • start amm_arb successfully
  • review filled orders handling is okay with no errors
  • curl:
    • wallet/add: ok
    • amm/price: ok
    • amm/trade: ok
  • Review quipuswap removed (as not-voted per previous poll)
  • Review uniswap_ethereum_sepolia added successfully
  • connected uniswap_ethereum_sepolia successfully

https://basescan.org/tx/0x16f8642137cc3b13cbcee47fb75c080c60e95dc92e965ccfe1aaaa69d7a3196e
image

image

@nikspz nikspz merged commit 70ca18a into development Jul 25, 2024
5 checks passed
@nikspz nikspz deleted the feat/add-uniswap-base branch July 25, 2024 16:48
@LautaroNavarro
Copy link

  • gateway connect uniswap_ethereum_base
    I'm in the development branch on both projects, hummingbot and gateway. The command gateway connect uniswap_ethereum_base is not working. The error is No available blockchain networks available for connector uniswap_ethereum_base.
    Is there something that I'm missing?

@LautaroNavarro
Copy link

I was able to connect to base sepolia but the balance being shown is not correct
Screenshot 2024-07-26 at 13 38 59
Screenshot 2024-07-26 at 13 39 44

@fengtality
Copy link
Contributor Author

Screenshot 2024-07-26 at 9 52 29 AM

works for me

sepolia is the Ethereum Sepolia testnet, not Base Sepolia. If you want to use Base Sepolia, submit a PR with the correct token list and addresses, etc

@nikspz nikspz mentioned this pull request Aug 12, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants