-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix / revised uniswap-base support #329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapcmia
changed the title
(fix) revised uniswap-base support
fix / revised uniswap-base support
Jun 3, 2024
c8e092b
|
@nikspz This PR is ready for testing. The tests still fail, but I'm working on a fix. |
This was referenced Jul 25, 2024
nikspz
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Cloned gwPR329 with Client latest development
- gateway connect uniswap_ethereum_base successfully
- added gateway connector-tokens WETH,USDC
- gateway balance now show WETH,USDC balance
- created amm_arb strategy using uniswap ethereum base
- start amm_arb successfully
- review filled orders handling is okay with no errors
- curl:
- wallet/add: ok
- amm/price: ok
- amm/trade: ok
- Review quipuswap removed (as not-voted per previous poll)
- Review uniswap_ethereum_sepolia added successfully
- connected uniswap_ethereum_sepolia successfully
https://basescan.org/tx/0x16f8642137cc3b13cbcee47fb75c080c60e95dc92e965ccfe1aaaa69d7a3196e
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: