Feat / Add Uniswap on chains BSC, Avalanche, and Celo #342

fengtality · 2024-07-25T17:55:05Z

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Adds Uniswap support for Binance Smart Chain, Avalanche, and Celo, refactored from community PRs
Fixes tests

Tests performed by the developer:

Tips for QA testing:

fengtality · 2024-07-26T14:25:45Z

@nikspz Can you test executing a Uniswap swap on development branch on:

Polygon Mainnet
Ethereum Arbitrum
Ethereum Optimism

I think this swaps issue exists on other networks on development branch as well. Still investigating.

nikspz · 2024-07-26T16:28:00Z

test executing a Uniswap swap on development branch on:

Polygon Mainnet

Ethereum Arbitrum

Ethereum Optimism

@fengtality

Development branch CLient + dev branch gateway:

(uniswap) Arbitrum:

amm/price: ok
amm/ trade: ok

(uniswap) Polygon:

amm/ trade: ok

(uniswap) Optimism

amm/ trade: ok

trades:
https://arbiscan.io/tx/0xdfca5bbceb780424e98462ae361ffaa5c2837de642843552d0f17ec20340be2e
https://optimistic.etherscan.io/tx/0xc35dcfe900d85a599685e9b04b67f921826aafd2f002266080a8ad049d9f0ba1
https://polygonscan.com/tx/0xc347c427eab9786b15955a1c2584acf5bc5d357ede3f2a437287ddcd90341b85

arbitrum

polygon

optimism

fengtality · 2024-07-26T18:39:52Z

The issue is that upgrading Uniswap swap order router above 3 breaks swaps on all Uniswap connectors.

However, not upgrading it results in the following error when fetching price on BSC:

"stack": "Error: No address for Uniswap Multicall Contract on chain id: 56\n    at new UniswapMulticallProvider (/Users/feng/gateway/node_modules/@uniswap/smart-order-router/build/main/providers/multicall-uniswap-provider.js:30:19)\n    at new AlphaRouter (/Users/feng/gateway/node_modules/@uniswap/smart-order-router/build/main/routers/alpha-router/alpha-router.js:47:97)\n    at new Uniswap (/Users/feng/gateway/dist/src/connectors/uniswap/uniswap.js:64:33)\n    at Uniswap.getInstance (/Users/feng/gateway/dist/src/connectors/uniswap/uniswap.js:90:51)\n    at /Users/feng/gateway/dist/src/services/connection-manager.js:134:51\n    at Generator.next (<anonymous>)\n    at /Users/feng/gateway/dist/src/services/connection-manager.js:8:71\n    at new Promise (<anonymous>)\n    at __awaiter (/Users/feng/gateway/dist/src/services/connection-manager.js:4:12)\n    at getConnector (/Users/feng/gateway/dist/src/services/connection-manager.js:131:12)"

I think this PR needs more work to figure out how to add support for Uniswap on other chains. Perhaps upgrading from using Swap Router 2 to Universal Router is needed.

fengtality · 2024-07-26T18:49:37Z

@nikspz I added a hacky fix, so I think Uniswap swaps should now work on BSC, Avalanche, and Celo.

nikspz · 2024-07-29T13:20:57Z

0cac4ea

arbitrum
- amm/price: ok
- amm/trade: ok
BSC mainnet
- amm/price: ok
- amm/trade: ok
Avalanche
- amm/price: ok
- amm/trade: ok
Celo
- amm/price: ok
- amm/trade: ok

BSC mainnet
price

trade

https://bscscan.com/tx/0xd5305cea3199544ab3d5f8e392f86cbd4f3e9ad3106cd5e14fff64bccdff4896

avalanche_avalanche
price

trade
https://snowtrace.io/tx/0xdda13d5aa26cfe566e5918fa2218a6a0957d1f0c63a33c3fd8536f051d04ce06

celo
price

trade
https://celoscan.io/tx/0x6403f92cbb4f407c5b2be3f3b2026e36c2b6d5c88a416f795e4ca767e4ac891b
https://celoscan.io/tx/0xa8824f6420fd2df84d7fc34bcb9407c636f50ddeb58811a427dffe25fb773f5d

nikspz · 2024-07-29T19:21:53Z

Failed to add uniswapLP for BSC mainnet, avalanche avalanche, connector (works for Celo)

Steps:

start the client with gateway set up
connect uniswapLP avalanche
failed to connect for connected and for new wallet

logs_hummingbot.log

2024-07-29 19:14:20,877 - 145951 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/chain/balances failed. See logs for more details.
2024-07-29 19:14:20,878 - 145951 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: Error on POST https://localhost:15888/chain/balances Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: No address for Uniswap Multicall Contract on chain id: 43114\n    at new UniswapMulticallProvider (/home/hummingbot/gwbsc/node_modules/@uniswap/smart-order-router/build/main/providers/multicall-uniswap-provider.js:30:19)\n    at new AlphaRouter (/home/hummingbot/gwbsc/node_modules/@uniswap/smart-order-router/build/main/routers/alpha-router/alpha-router.js:47:97)\n    at new UniswapLPHelper (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:76:33)\n    at new UniswapLP (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.js:44:9)\n    at UniswapLP.getInstance (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.js:52:53)\n    at /home/hummingbot/gwbsc/dist/src/services/connection-manager.js:137:56\n    at Generator.next (<anonymous>)\n    at /home/hummingbot/gwbsc/dist/src/services/connection-manager.js:8:71\n    at new Promise (<anonymous>)\n    at __awaiter (/home/hummingbot/gwbsc/dist/src/services/connection-manager.js:4:12)'}
Traceback (most recent call last):
  File "/home/hummingbot/dev2/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/hummingbot/dev2/hummingbot/client/command/gateway_command.py", line 369, in _gateway_connect
    balances: Dict[str, Any] = await self._get_gateway_instance().get_balances(
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 293, in get_balances
    return await self.api_request(
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 222, in api_request
    raise e
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 210, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/chain/balances Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: No address for Uniswap Multicall Contract on chain id: 43114\n    at new UniswapMulticallProvider (/home/hummingbot/gwbsc/node_modules/@uniswap/smart-order-router/build/main/providers/multicall-uniswap-provider.js:30:19)\n    at new AlphaRouter (/home/hummingbot/gwbsc/node_modules/@uniswap/smart-order-router/build/main/routers/alpha-router/alpha-router.js:47:97)\n    at new UniswapLPHelper (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:76:33)\n    at new UniswapLP (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.js:44:9)\n    at UniswapLP.getInstance (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.js:52:53)\n    at /home/hummingbot/gwbsc/dist/src/services/connection-manager.js:137:56\n    at Generator.next (<anonymous>)\n    at /home/hummingbot/gwbsc/dist/src/services/connection-manager.js:8:71\n    at new Promise (<anonymous>)\n    at __awaiter (/home/hummingbot/gwbsc/dist/src/services/connection-manager.js:4:12)'}

Works for arbitrum:

0cac4ea

Amm_arb strategy works for avalanche and BSC
Amm_LP: created LP position succesffully: https://celoscan.io/tx/0xa14ebab3ac2ce3800059f1d08e82c5adc5fce373e31b596b6641a1a515a427ef
Curl:
- arbitrum
  - amm/price: ok
  - amm/trade: ok
- BSC mainnet
  - amm/price: ok
  - amm/trade: ok
- Avalanche
  - amm/price: ok
  - amm/trade: ok
- Celo
  - amm/price: ok
  - amm/trade: ok

fengtality · 2024-07-29T21:07:52Z

@nikspz thanks - i fixed the uniswaplp bug

nikspz · 2024-07-30T11:07:25Z

7e565d4
Test performed:

Amm_arb strategy works for avalanche and BSC
Curl:
- arbitrum
  - amm/price: ok
  - amm/trade: ok
- BSC mainnet
  - amm/price: ok
  - amm/trade: ok
  - amm/liquidity/add: ok
  - amm/liquidity/remove: ok
- Avalanche
  - amm/price: ok
  - amm/trade: ok
  - amm/liquidity/add: ok
  - amm/liquidity/remove: ok
- Celo
  - amm/price: ok
  - amm/trade: ok
Amm_LP: created LP position succesffully:
- Unable to fetch pool state (avalanche, BSC)

Celo:

add position: ok

Remove: ok

BSC
add position - ok, position added, however Unable to fetch status

logs_conf_amm_v3_lp_2.log

2024-07-30 10:54:57,404 - 154436 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/liquidity/position failed. See logs for more details.
2024-07-30 10:54:57,405 - 154436 - GatewayEVMAMMLP - ERROR - Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
Traceback (most recent call last):
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 1097, in _status_polling_loop
    await safe_gather(
  File "/home/hummingbot/dev2/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 970, in update_nft
    raise nft_update_result
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 818, in amm_lp_position
    return await self.api_request("post", "amm/liquidity/position", request_payload)
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 222, in api_request
    raise e
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 210, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
2024-07-30 10:55:08,615 - 154436 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/liquidity/position failed. See logs for more details.
2024-07-30 10:55:08,615 - 154436 - GatewayEVMAMMLP - ERROR - Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
Traceback (most recent call last):
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 1097, in _status_polling_loop
    await safe_gather(
  File "/home/hummingbot/dev2/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 970, in update_nft
    raise nft_update_result
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 818, in amm_lp_position
    return await self.api_request("post", "amm/liquidity/position", request_payload)
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 222, in api_request
    raise e
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 210, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}

https://bscscan.com/tx/0xf5fc4964726d7d02338413f8626a31d84350971bbd859a276d97028ef0b55f4e

remove position: ok

avalanche_avalanche

add position: ok Position created
issue on amm_v3_LP, not sure if related to node.

logs_conf_amm_v3_lp_1.log

2024-07-30 09:11:37,189 - 152703 - GatewayEVMAMMLP - ERROR - Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
Traceback (most recent call last):
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 1097, in _status_polling_loop
    await safe_gather(
  File "/home/hummingbot/dev2/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 970, in update_nft
    raise nft_update_result
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 818, in amm_lp_position
    return await self.api_request("post", "amm/liquidity/position", request_payload)
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 222, in api_request
    raise e
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 210, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
2024-07-30 09:11:38,529 - 152703 - GatewayEVMAMMLP - ERROR - Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
Traceback (most recent call last):
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 1097, in _status_polling_loop
    await safe_gather(
  File "/home/hummingbot/dev2/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 970, in update_nft
    raise nft_update_result
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 818, in amm_lp_position
    return await self.api_request("post", "amm/liquidity/position", request_payload)
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 222, in api_request
    raise e
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 210, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
2024-07-30 09:11:39,186 - 152703 - GatewayEVMAMMLP - ERROR - Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}
Traceback (most recent call last):
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 1097, in _status_polling_loop
    await safe_gather(
  File "/home/hummingbot/dev2/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/hummingbot/dev2/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 970, in update_nft
    raise nft_update_result
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 818, in amm_lp_position
    return await self.api_request("post", "amm/liquidity/position", request_payload)
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 222, in api_request
    raise e
  File "/home/hummingbot/dev2/hummingbot/core/gateway/gateway_http_client.py", line 210, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/position Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Unable to fetch pool state\n    at UniswapLP.<anonymous> (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:179:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/hummingbot/gwbsc/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'}

Remove position: ok

amm/liquidity/position failed on curl as well, could be fixed in the next PR

nikspz · 2024-07-30T18:35:50Z

amm/liquidity/position failed on curl as well, could be fixed in the next PR

fengtality · 2024-07-31T01:49:05Z

@nikspz I took a quick look at the /amm/liquidity/position issue but it requires more investigation. Looks like the position is successfully created but doing the tokenID lookup fails for some reason.

I suggest that we merge this PR in, and then I'll look at the LP functionality separately.

nikspz

merge this PR in, to look at the LP functionality separately.

elijahsnoz and others added 30 commits April 20, 2024 14:03

(feat) celo network

71d3ee6

(feat) celo network

823e19a

(feat) celo network

2d17d4d

(feat) Ethereum avalache integration

afdc6e7

Merge branch 'development' into feat/uniswap_avalanche

e95c161

(feat) celo nft refactor

28ea387

(feat) Updated smart-router

881e10d

(feat) test filerefactor

e04d8f4

(feat) test filerefactor

eb8b6c2

(feat) test filerefactor

a0ece41

update smart-router

f55e034

(fix) update uniswap packages

4d7e47b

(fix) update uniswap packages

c50671a

(fix) update uniswap packages

2323d04

Merge branch 'development' into feat/celo_chain/network

621dc44

(feat) Add avalance on unswap ethereum network

c045cfa

Merge branch 'development' into feat/uniswap_avalanche

8ef1e19

Merge branch 'development' into feat/celo_chain/network

a071bdc

Merge branch 'development' into feat/uniswap_avalanche

59f9054

(feat) factory adddress added

d031360

(feat) Update FactoryAddress impllementation

bd4f891

(feat) Update celo tokenlist

f721dd8

(feat) Update celo tokenlist

a5d08be

(feat) remove changes to test

1231296

(fix) uniswap pool address

cf42853

(refactor) Uniswap_avalanche on avalanche chain

755af3a

(refactor) token list

04bf8a0

(refactor) test file

1132790

(refactor) token list file

296cf6e

Merge branch 'development' into feat/celo_chain/network

e0334e0

fengtality added 6 commits July 26, 2024 10:51

remove extraneous change

8707dc9

remove extraneous change 2

cca1510

revert more changes

c8cb59d

revert package.json changes

8e4c74c

revert yarn lock

7c6842b

replace yarn.lock dev

ce21d40

fengtality changed the title ~~Harjas27 feat/uniswap BSC, Avalanche, and Celo~~ feat/uniswap BSC, Avalanche, and Celo Jul 26, 2024

fengtality changed the title ~~feat/uniswap BSC, Avalanche, and Celo~~ Feat / Add Uniswap on chains BSC, Avalanche, and Celo Jul 26, 2024

(hack) add list of excluded router chains

3db080c

fengtality mentioned this pull request Jul 26, 2024

Feat/uniswap updates #345

Merged

(fix) fix uniswap config networks

0cac4ea

Merge branch 'development' into harjas27-feat/uniswap_bsc

e98d888

fengtality mentioned this pull request Jul 29, 2024

uniswap_ethereum_mainnet connector not listed when creating pure_market_making strategy hummingbot/hummingbot#7146

Closed

(fix) exclude router on certain chains

7e565d4

nikspz previously approved these changes Jul 30, 2024

View reviewed changes

nikspz approved these changes Jul 31, 2024

View reviewed changes

nikspz merged commit bd5573e into development Jul 31, 2024
4 of 5 checks passed

nikspz deleted the harjas27-feat/uniswap_bsc branch July 31, 2024 04:03

nikspz mentioned this pull request Aug 12, 2024

sync / gateway development -> staging #348

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat / Add Uniswap on chains BSC, Avalanche, and Celo #342

Feat / Add Uniswap on chains BSC, Avalanche, and Celo #342

fengtality commented Jul 25, 2024 •

edited

Loading

fengtality commented Jul 26, 2024

nikspz commented Jul 26, 2024 •

edited

Loading

fengtality commented Jul 26, 2024

fengtality commented Jul 26, 2024

nikspz commented Jul 29, 2024

nikspz commented Jul 29, 2024 •

edited

Loading

fengtality commented Jul 29, 2024

nikspz commented Jul 30, 2024 •

edited

Loading

nikspz commented Jul 30, 2024

fengtality commented Jul 31, 2024

nikspz left a comment

Feat / Add Uniswap on chains BSC, Avalanche, and Celo #342

Feat / Add Uniswap on chains BSC, Avalanche, and Celo #342

Conversation

fengtality commented Jul 25, 2024 • edited Loading

fengtality commented Jul 26, 2024

nikspz commented Jul 26, 2024 • edited Loading

fengtality commented Jul 26, 2024

fengtality commented Jul 26, 2024

nikspz commented Jul 29, 2024

nikspz commented Jul 29, 2024 • edited Loading

fengtality commented Jul 29, 2024

nikspz commented Jul 30, 2024 • edited Loading

nikspz commented Jul 30, 2024

fengtality commented Jul 31, 2024

nikspz left a comment

Choose a reason for hiding this comment

fengtality commented Jul 25, 2024 •

edited

Loading

nikspz commented Jul 26, 2024 •

edited

Loading

nikspz commented Jul 29, 2024 •

edited

Loading

nikspz commented Jul 30, 2024 •

edited

Loading