Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/wallet data feed hedge #6496

Merged
merged 11 commits into from
Jul 24, 2023
Merged

Conversation

fengtality
Copy link
Contributor

@fengtality fengtality commented Jul 20, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

@rapcmia
Copy link
Contributor

rapcmia commented Jul 21, 2023

PR update:

  • Overview of the PR
  • Testing this script requires user to add wallet first
  • wallet_hedge_example
    image
    • Works with other tokens as long as it has balance
    • Works with two different wallets
      image
      • Observed that the balance has the total amount of the two wallets
    • If Token has no balance, no other info is displayed
      image

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@cardosofede
Copy link
Contributor

@fengtality I will merge it, do you think that we should create the issue on GitHub to allow requesting info of other wallets for the gateway?

@cardosofede cardosofede merged commit 4497543 into development Jul 24, 2023
@cardosofede cardosofede deleted the feat/wallet-data-feed-hedge branch July 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants