-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/leverage type (from decimal to int) #6504
Fix/leverage type (from decimal to int) #6504
Conversation
Test performed:
|
@nikspz Please also run another perpetual strategy like spot_perpetual_arbitrage or perpetual_market_making to check that there's no impact on non-directional strategies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Ran directional_strategy_bb_rsi_multi_timeframe, reviewed overnight performance was good.
- Created/ran spot-perpetual using binance and binance perpetual
- Ran simple perpetualMM strategy using binance perpetual
- Reviewed OPEN orders placed and CLOSE: stop-loss and take profit order closed, according to config: ok
Merged to development and will be part of |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
The type hint of the position config invites you to use a Decimal value for the leverage when it's an integer.
If you use a decimal you get an error in the database when trying to query the orders with the market recorder.
Tests performed by the developer:
Run a directional strategy that uses leverage Decimal("10") instead of 10
Tips for QA testing: