Don't write pref on initial load, per review

humphd · May 5, 2015 · 3a09a13 · 3a09a13
1 parent 83eb276
commit 3a09a13
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/extensions/default/JavaScriptCodeHints/thirdparty/acorn b/src/extensions/default/JavaScriptCodeHints/thirdparty/acorn
diff --git a/src/extensions/default/JavaScriptCodeHints/thirdparty/tern b/src/extensions/default/JavaScriptCodeHints/thirdparty/tern
diff --git a/src/extensions/default/QuickView/main.js b/src/extensions/default/QuickView/main.js
@@ -739,11 +739,13 @@ define(function (require, exports, module) {
         CommandManager.get(CMD_ENABLE_QUICK_VIEW).setChecked(enabled);
     }
 
-    function setExtensionlessImagePreview(_extensionlessImagePreview) {
+    function setExtensionlessImagePreview(_extensionlessImagePreview, doNotSave) {
         if(extensionlessImagePreview !== _extensionlessImagePreview) {
             extensionlessImagePreview = _extensionlessImagePreview;
-            prefs.set("extensionlessImagePreview", enabled);
-            prefs.save();
+            if (!doNotSave) {
+                prefs.set("extensionlessImagePreview", enabled);
+                prefs.save();
+            }
         }
     }
 
@@ -814,7 +816,7 @@ define(function (require, exports, module) {
 
     // Setup initial UI state
     setEnabled(prefs.get("enabled"), true);
-    setExtensionlessImagePreview(prefs.get("extensionlessImagePreview"));
+    setExtensionlessImagePreview(prefs.get("extensionlessImagePreview"), true);
 
     prefs.on("change", "enabled", function () {
         setEnabled(prefs.get("enabled"), true);