Patch react native gifted #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @hungvu193 I was planning to migrate lib to typescript so It will be easier to inherit props from react-native-gifted-chat and to help code editors on autocomplete. What do you think? |
|
That’s good point, I have a plan to migrate to Typescript but I was so busy
in another projects, feel free to open PR 🤩
…On Sat, 18 Dec 2021 at 01:53 Jonathan Vargas ***@***.***> wrote:
Hello, @hungvu193 <https://github.com/hungvu193> I was planning to
migrate lib to typescript so It will be easier to inherit props from
react-native-gifted-chat and to help code editors on autocomplete. What do
you think?
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD544MBDE4LUTMFDQ77REMDUROBI5ANCNFSM5KHRDFVQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits solves this Keyboard (warning/error) of react-native-gifted-chat. Which cause compatibility problems when adding the lib on existing react projects
FaridSafi/react-native-gifted-chat#2090