Allow building on stable 1.6.0 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! You should hear from @huonw (or someone else) soon. |
sapphire-arches
force-pushed
the
stable-1.6.0-patch
branch
from
2dfaa0b to
209da42
Compare
|
Since Travis is apparently running the 1.7 beta, I have pushed a commit that requires implementors of |
Open
- Remove dependency on std::sync::StaticMutex by replacing it with a
std::sync::Mutex initialized by lazy_static.
- Replace use of unstable std::raw::Slice with std::slice::from_raw_parts
- Replace use of depreciated Path.as_os_str().to_cstring()
Replace use of clone_from_slice with an explicity copy
sapphire-arches
force-pushed
the
stable-1.6.0-patch
branch
from
209da42 to
ff1a21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches allows the library to build and tests to run on the current (1.6.0) stable release of Rust. Some of these changes should probably be made regardless:
std::raw::Sliceisn't going to go in:std::slice::from_raw_parts{,_mut}does the same thing and is already stable (Tracking issue forrawstabilization (raw::TraitObject) rust-lang/rust#27751)OsStr.to_cstring()is deprecated and will be removed in a future release, so we can't rely on it (RFC: Stabilize OS string to bytes conversions rust-lang/rfcs#1255)If you want to pull in just those changes, just let me know and I'll pull them out in to a different PR.