Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making nightly --features passing smarter #33

Open
huonw opened this issue Nov 7, 2015 · 3 comments
Open

Consider making nightly --features passing smarter #33

huonw opened this issue Nov 7, 2015 · 3 comments

Comments

@huonw
Copy link
Owner

huonw commented Nov 7, 2015

Currently travis-cargo will pass --features $TRAVIS_CARGO_NIGHTLY_FEATURE, or --features unstable if that env var doesn't exist. It might be nice to make this more intelligent by default, by parsing the toml file to look for a feature either unstable or nightly and pass that, falling back to passing nothing if neither exist (but still obeying the env var override).

@huonw huonw changed the title Consider making nightly --feature passing smarter Consider making nightly --features passing smarter Nov 7, 2015
@jdub
Copy link

jdub commented Nov 7, 2015

In the meantime, for those who stumble on this, here's the workaround for .travis.yml as suggested by @huonw:

env:
  global:
    - TRAVIS_CARGO_NIGHTLY_FEATURE=""

@huonw
Copy link
Owner Author

huonw commented Nov 13, 2015

I've seen "dev" used as the name of this feature in the wild too.

@jdub
Copy link

jdub commented Apr 1, 2017

Interesting corner case on this one: You can't set an empty environment variable in Windows. Setting an environment variable to "" deletes it.

Yes, you now have a travis-cargo user on Windows / Appveyor. 😄

https://ci.appveyor.com/project/jdub/pathfinder/build/job/c54yd248q6qbeo8p

And this is not some quixotic quest! There is a working build for stable:

https://ci.appveyor.com/project/jdub/pathfinder/build/job/lvejvt96aflpd9xb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants