-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider making nightly --features passing smarter #33
Comments
In the meantime, for those who stumble on this, here's the workaround for env:
global:
- TRAVIS_CARGO_NIGHTLY_FEATURE="" |
I've seen " |
This is a workaround until resolution of issue #33 on `travis-cargo`. See huonw/travis-cargo#33
Interesting corner case on this one: You can't set an empty environment variable in Windows. Setting an environment variable to "" deletes it. Yes, you now have a https://ci.appveyor.com/project/jdub/pathfinder/build/job/c54yd248q6qbeo8p And this is not some quixotic quest! There is a working build for stable: https://ci.appveyor.com/project/jdub/pathfinder/build/job/lvejvt96aflpd9xb |
Currently travis-cargo will pass
--features $TRAVIS_CARGO_NIGHTLY_FEATURE
, or--features unstable
if that env var doesn't exist. It might be nice to make this more intelligent by default, by parsing the toml file to look for a feature eitherunstable
ornightly
and pass that, falling back to passing nothing if neither exist (but still obeying the env var override).The text was updated successfully, but these errors were encountered: