Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to stop travis-cargo from adding a feature flag on nightly #5

Closed
Aatch opened this issue May 31, 2015 · 4 comments
Closed

No way to stop travis-cargo from adding a feature flag on nightly #5

Aatch opened this issue May 31, 2015 · 4 comments

Comments

@Aatch
Copy link

Aatch commented May 31, 2015

Not a huge problem, since you can always just add a dummy feature to Cargo.toml but if you don't actually need a feature for unstable/nightly, it's a bit annoying that you can't tell travis-cargo that you don't want a flag at all.

@huonw
Copy link
Owner

huonw commented Jun 2, 2015

You can set TRAVIS_CARGO_NIGHTY_FEATURE="" which will remove this problem. (I'm still unsure about whether I want to implement a "real" way to disable it or not.)

@Aatch
Copy link
Author

Aatch commented Jun 2, 2015

I tried that, it treats an empty string as it not being there (I think) and uses the default.

@elinorbgr
Copy link

A workaround would be setting the variable to " ", which cargo interprets as an empty features list.

However, there are also situations where cargo simply refuses to get a --features flag.
I have a project consisting of several libs in the same git repo, that I used to test using commands like

cargo test -p foo

But after migrating to travis-cargo, cargo complains that

features cannot be modified when the main package is not being built

It would really be nice to have a way to completely disable passing the --features flag.

@huonw
Copy link
Owner

huonw commented Sep 2, 2015

@vberger the -p problem is covered by #14 (which I'm pushing a fix for in the next few minutes).

huonw added a commit that referenced this issue Sep 2, 2015
This fixes several bugs: #5, #6, #14, #18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants