Fix coverage subcommand #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Failure seems to only be against nightly... not sure why it can't find the crate. Ran my fork against rust-rosetta/rust-rosetta#537 and it found the dylibs correctly. |
This was referenced Aug 24, 2016
maurer
added a commit
to maurer/holmes
that referenced
this pull request
Jan 9, 2017
Directly use huonw/travis-cargo#55 until it lands
maurer
added a commit
to maurer/holmes
that referenced
this pull request
Jan 9, 2017
Directly use huonw/travis-cargo#55 until it lands
maurer
added a commit
to maurer/holmes
that referenced
this pull request
Jan 9, 2017
Directly use huonw/travis-cargo#55 until it lands
maurer
added a commit
to maurer/holmes
that referenced
this pull request
Jan 9, 2017
Directly use huonw/travis-cargo#55 until it lands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargoredirected most of its output from stdout to stderr in rust-lang/cargo#2693. Great for redirecting, bad for scraping!Fixed by redirecting stdout to stderr in the output-capturing helper functions. Not the most elegant solution, but a backwards-compatible one.
Fixes #54.