Fix strings detection (#78)

huozhi · Sep 17, 2023 · f7c7082 · f7c7082 · vercel · Sep 17, 2023
1 parent 18245fd
commit f7c7082
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/index.mjs b/lib/index.mjs
@@ -218,12 +218,19 @@ function tokenize(code) {
    */
   function classify(token) {
     const isLineBreak = token === '\n'
+    // First checking if they're attributes values
     if (inJsxTag() && inStringQuotes()) {
       return T_STRING
     }
+    // Then determine if they're jsx literals
     const isJsxLiterals = inJsxLiterals()
     if (isJsxLiterals) {
       return T_JSX_LITERALS
+
+    }
+    // Determine strings first before other types
+    if (inStringQuotes()) {
+      return T_STRING
     } else if (keywords.has(token)) {
       return last[1] === '.' ? T_IDENTIFIER : T_KEYWORD
     } else if (isLineBreak) {

diff --git a/test/ast.test.js b/test/ast.test.js
@@ -403,6 +403,17 @@ describe('strings', () => {
       'keyword', 'identifier', 'sign', 'string', 'string', 'string',
     ])
   })
+
+  it('number in string', () => {
+    const code = `'123'\n'true'`
+    const tokens = tokenize(code)
+    expect(extractTokenValues(tokens)).toEqual([
+      "'", '123', "'", "'", 'true', "'",
+    ])
+    expect(extractTokensTypes(tokens)).toEqual([
+      'string', 'string', 'string', 'break', 'string', 'string', 'string',
+    ])
+  })
 })
 
 describe('class', () => {