use network_mode host #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaPolit
reviewed
Jan 10, 2022
src/ServiceConfig.py
Outdated
Comment on lines
138
to
144
| # port = None | ||
| # if os.path.exists("docker-compose.yml"): | ||
| # with open("docker-compose.yml", "r") as f: | ||
| # docker_yml = yaml.safe_load(f) | ||
| # services = list(docker_yml["services"].keys()) | ||
| # port = docker_yml["services"][services[0]]["ports"][0].split(":")[0] | ||
|
|
There was a problem hiding this comment.
This commented lines are supposed to be kept?
daneryl
force-pushed
the
network_mode_host
branch
from
767cb1d
to
c2ba275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change docker-compose to use network_mode: host, this fixes a couple of issues when used with ufw firewall.