fix armv7 #22
Merged
fix armv7 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustup uses a different naming scheme from ansible, the name needs to be replaced for arm to work. not sure if more architectures have this problem
|
Awesome! I will definitely get this looked at today
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: paperbenni ***@***.***>
Sent: Thursday, November 16, 2023 10:28:01 AM
To: hurricanehrndz/ansible-rustup ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [hurricanehrndz/ansible-rustup] fix armv7 (PR #22)
rustup uses a different naming scheme from ansible, the name needs to be replaced for arm to work. Not sure if more architectures have this problem. Maybe we need a full conversion table, or maybe there is a less hacky way to fix this, but this fixes the role on a raspberry pi
________________________________
You can view, comment on, or merge this pull request online at:
#22
Commit Summary
* e1a5781<e1a5781> hacky fix for armv7
* 6d58775<6d58775> Merge branch 'master' of https://github.com/hurricanehrndz/ansible-rustup
* edc34c8<edc34c8> fix arm name
File Changes
(1 file<https://github.com/hurricanehrndz/ansible-rustup/pull/22/files>)
* M tasks/set-toolchain.yml<https://github.com/hurricanehrndz/ansible-rustup/pull/22/files#diff-5afd0efe26b3e47cd83e27538fcce59ae525865094ed0a652308ca382155bef9> (2)
Patch Links:
* https://github.com/hurricanehrndz/ansible-rustup/pull/22.patch
* https://github.com/hurricanehrndz/ansible-rustup/pull/22.diff
—
Reply to this email directly, view it on GitHub<#22>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMJBTPAIQUFWM754RE3KT3YEZEKDAVCNFSM6AAAAAA7OQZEY6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TOMZZGE3DOOA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustup uses a different naming scheme for cpu architectures from ansible, the name needs to be replaced for arm to work. Not sure if more architectures have this problem. Maybe we need a full conversion table, or maybe there is a less hacky way to fix this, but this fixes the role on a raspberry pi