Merge pull request #12 from edwink75/bugfix-cached-tabs

Compatibility with FIlament 3.0.47 and later
husam-tariq · Oct 7, 2023 · 49ab6e9 · 49ab6e9
2 parents 069729f + 51e5e62
commit 49ab6e9
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 10 deletions.
diff --git a/composer.json b/composer.json
@@ -18,7 +18,7 @@
     "require": {
         "php": "^8.0",
         "awcodes/filament-table-repeater": "^2.0.4",
-        "filament/filament": "^3.0.5",
+        "filament/filament": "^3.0.47",
         "spatie/laravel-package-tools": "^1.13.5",
         "illuminate/contracts": "^8.0|^9.0|^10.0"
     },

diff --git a/config/filament-database-schedule.php b/config/filament-database-schedule.php
@@ -41,6 +41,11 @@
      */
     "navigation_icon" => 'heroicon-o-rectangle-stack',
 
+    /**
+     * When opening history, is output collapsed
+     */
+    'history_collapsed' => env('FILAMENT_SCHEDULE_HISTORY_COLLAPSED', false),
+
     /**
      * How many jobs do you want to have on each page ?
      */

diff --git a/resources/views/layouts/schedule-history-layout.blade.php b/resources/views/layouts/schedule-history-layout.blade.php
@@ -0,0 +1,6 @@
+<div>
+    <h1 class="fi-header-heading text-2xl font-bold tracking-tight text-gray-950 dark:text-white sm:text-3xl">
+        {{ __("filament-database-schedule::schedule.resource.history") }}
+    </h1>
+    {{ $this->table }}
+</div>
diff --git a/src/Filament/Columns/ScheduleArguments.php b/src/Filament/Columns/ScheduleArguments.php
@@ -39,7 +39,6 @@ public function getTags(): array
       if (count($tags) === 1 && blank($tags[0])) {
           $tags = [];
       }
-dd($tags);
       return $tags;
   }
 }
diff --git a/src/Filament/Resources/ScheduleResource/Pages/ViewSchedule.php b/src/Filament/Resources/ScheduleResource/Pages/ViewSchedule.php
@@ -7,6 +7,7 @@
 use Filament\Forms;
 use Filament\Resources\Pages\Page;
 use Filament\Resources\Pages\Concerns\HasRelationManagers;
+use Filament\Resources\Concerns\HasTabs;
 use Filament\Resources\Pages\Concerns\InteractsWithRecord;
 use Livewire\Attributes\Url;
 
@@ -23,16 +24,11 @@ class ViewSchedule extends Page implements HasTable
     protected static string $view = 'filament-panels::resources.pages.list-records';
     use InteractsWithRecord;
     use HasRelationManagers;
+    use HasTabs;
 
     #[Url]
     public ?string $activeTab = null;
-    /**
-     * @return array<string | int, Tab>
-     */
-    public function getTabs(): array
-    {
-        return [];
-    }
+
     use Forms\Concerns\InteractsWithForms;
     use Tables\Concerns\InteractsWithTable {
         makeTable as makeBaseTable;
@@ -85,7 +81,7 @@ protected function getTableColumns(): array
                 Tables\Columns\TextColumn::make('output')->extraAttributes(["class"=>"!max-w-max"],true),
 
 
-            ])->collapsible(),
+            ])->collapsible()->collapsed(config("filament-database-schedule.history_collapsed")),
 
         ];
     }