Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ros2 update #36

Merged
merged 24 commits into from
Mar 18, 2024
Merged

Ros2 update #36

merged 24 commits into from
Mar 18, 2024

Conversation

rafal-gorecki
Copy link
Contributor

Description

  • add Docker with ros2 image for physical Panther and simulation
  • decrease number of compose configurations
  • optimized building time 25% and image size 10%
  • changes in readme

@rafal-gorecki rafal-gorecki requested a review from KmakD March 5, 2024 11:19
KmakD
KmakD requested changes Mar 8, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Dockerfile.hardware Outdated Show resolved Hide resolved
Dockerfile.hardware Show resolved Hide resolved
demo/compose.rviz.yaml Show resolved Hide resolved
demo/compose.rviz.yaml Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
demo/panther.rviz Outdated Show resolved Hide resolved
@rafal-gorecki rafal-gorecki requested a review from KmakD March 8, 2024 11:32
KmakD
KmakD reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@KmakD KmakD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I screw a bit but adding comments directly, not in review, so this dummy comment 😅

@rafal-gorecki rafal-gorecki requested a review from KmakD March 18, 2024 10:17
KmakD
KmakD requested changes Mar 18, 2024
View reviewed changes
demo/compose.rviz.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rafal-gorecki and others added 2 commits March 18, 2024 15:18
@rafal-gorecki @KmakD
Update README.md
e3c50f1 
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
@rafal-gorecki @KmakD
Update demo/compose.rviz.yaml
60f1744 
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
@KmakD KmakD merged commit 0156b69 into ros2-devel Mar 18, 2024
@KmakD KmakD deleted the ros2-update branch March 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KmakD KmakD KmakD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafal-gorecki @KmakD