Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS 2 add Roboteq Battery #206

Merged
merged 108 commits into from
Nov 14, 2023
Merged

ROS 2 add Roboteq Battery #206

merged 108 commits into from
Nov 14, 2023

Conversation

KmakD
Copy link
Contributor

@KmakD KmakD commented Nov 6, 2023

No description provided.

KmakD and others added 30 commits June 27, 2023 12:18
@KmakD
add adc data reader
788fdf3
@KmakD
add adc node and tests
d728761
@KmakD
update nodes and tests
90fbf32
@KmakD
add readings timeout
dc2c07a
@KmakD
update tests
daf4bf9
@KmakD
data reader fixes
96a621e
@KmakD @Kotochleb
Update panther_battery/README.md
d0c410b 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
e12e4cd 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
168f007 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
4d29dd6 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
4c758c8 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
eabf5cc 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
b24c519 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD
review fixes
3311fc3
@KmakD
add adc to battery converter
bc1c377
@KmakD
battery class
6416873
@KmakD
battery params
b5424c0
@KmakD
fix republisher node
2d2da7a
@KmakD
update adc node
304910c
@KmakD
update tests
4054ac8
@KmakD
update adc_node test
edd0394
@KmakD
small fixes and formating
3ecc28b
@KmakD
update headers and create battery.cpp
b7b2e8a
@KmakD
use shared ptr for adc readers
ad1cbeb
@KmakD @Kotochleb
Update panther_battery/include/panther_battery/battery.hpp
f6e0b1f 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/include/panther_battery/adc_data_reader.hpp
514f444 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/include/panther_battery/adc_data_reader.hpp
2b8bc5e 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/include/panther_battery/adc_data_reader.hpp
04d5350 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/include/panther_battery/adc_data_reader.hpp
13f6d6b 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/include/panther_battery/adc_data_reader.hpp
82e5329 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
KmakD and others added 11 commits October 23, 2023 07:29
@KmakD
remove unnecessary try catch
fb93f4d
@KmakD
add roboteq battery and battery node
16295c2
@KmakD
add roboteq battery tests
56aa56d
@KmakD
validate driver state in roboteq_battery
c015112
@KmakD
update includes
b5ba9e9
@KmakD @Kotochleb
ROS 2 adc node refactor (#202)
b37c511 
* update adc_data_reader

* add battery_publisher class

* clean up battery class

* separate headers for bat publishers

* add adc_battery subclass

* update battery publisher

* fix ADCBattery

* fix error logging

* add battery tests

* add battery_publisher test

* add single and dual battery publisher tests

* Update panther_battery/src/adc_node.cpp

Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>

* review fixes

* formating and small fixes

* update readme

* Update panther_battery/src/battery_publisher.cpp

Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>

* Update panther_battery/src/battery_publisher.cpp

Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>

* Update panther_battery/src/battery_publisher.cpp

Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>

* Update panther_battery/src/battery_publisher.cpp

Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>

* Update panther_battery/include/panther_battery/adc_data_reader.hpp

Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>

* review fixes

* add MergeBatteryPowerSupplyHealth method

* code formatting

* fix bat params order

* review fixes

* update test_utils and add test for it

* update tests

* remove unnecessary try catch

* update battery virtual methods

* review fixes

* small fix

* fixes again

* change MergeBatteryPowerSupplyStatus logic

---------

Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD
Merge branch 'ros2-adc-node' of https://github.com/husarion/panther_ros…
981cf03 
… into ros2-roboteq-battery
@KmakD
update CmakeLists
005ea3a
@KmakD
update README
da3c00f
@KmakD
Merge branch 'ros2-devel' of https://github.com/husarion/panther_ros …
6cd1a7d 
…into ros2-roboteq-battery
@KmakD
remove unnecessary files
a813268
@KmakD KmakD requested a review from Kotochleb November 7, 2023 12:04
Kotochleb
Kotochleb suggested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Kotochleb Kotochleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments start with upper case and some with lower case. I think starting all comments that start at the beginning of a sentence with an upper case letter would be a good idea

panther_battery/README.md Outdated Show resolved Hide resolved
panther_battery/README.md Outdated Show resolved Hide resolved
panther_battery/README.md Outdated Show resolved Hide resolved
panther_battery/README.md Outdated Show resolved Hide resolved
panther_battery/src/battery_node.cpp Outdated Show resolved Hide resolved
panther_battery/include/panther_battery/roboteq_battery.hpp Show resolved Hide resolved
panther_battery/src/roboteq_battery.cpp Outdated Show resolved Hide resolved
panther_battery/src/roboteq_battery.cpp Show resolved Hide resolved
panther_battery/test/test_battery_node_roboteq.cpp Show resolved Hide resolved
panther_battery/test/test_roboteq_battery.cpp Outdated Show resolved Hide resolved
KmakD and others added 5 commits November 14, 2023 09:19
@KmakD @Kotochleb
Update panther_battery/README.md
f5ae68a 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
7a63845 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD @Kotochleb
Update panther_battery/README.md
a8f6d4e 
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD
review fixes
5611bde
@KmakD
add unused param comments
8382c67
@KmakD KmakD requested a review from Kotochleb November 14, 2023 09:54
Kotochleb
Kotochleb suggested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Kotochleb Kotochleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in lines 64-66 in adc_battery.hpp could be better formatted. Other comments are also not beginning with upper case letters.

@KmakD KmakD requested a review from Kotochleb November 14, 2023 12:35
@Kotochleb Kotochleb merged commit 58aea63 into ros2-devel Nov 14, 2023
@Kotochleb Kotochleb deleted the ros2-roboteq-battery branch November 14, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kotochleb Kotochleb Kotochleb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KmakD @Kotochleb