Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS 2 panther lights #210

Merged
merged 32 commits into from
Nov 28, 2023
Merged

ROS 2 panther lights #210

merged 32 commits into from
Nov 28, 2023

Conversation

KmakD
Copy link
Contributor

@KmakD KmakD commented Nov 17, 2023

Parts with usage of the libgpiod will change when separate class for GPIO handling is introduced. Don't pay too much attention to this parts of the code.
I have no idea why panther_battery/package.xml is shown as it was modified - it didn't change.

Copy link
Contributor

@Kotochleb Kotochleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing tests checking whether the frame is correctly parsed

panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/driver_node.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/driver_node.cpp Outdated Show resolved Hide resolved
panther_lights/include/panther_lights/apa102.hpp Outdated Show resolved Hide resolved
KmakD and others added 7 commits November 21, 2023 15:15
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD KmakD requested a review from Kotochleb November 22, 2023 12:07
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/include/panther_lights/apa102.hpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
panther_lights/src/driver_node.cpp Show resolved Hide resolved
KmakD and others added 3 commits November 27, 2023 09:29
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD KmakD requested a review from Kotochleb November 27, 2023 10:25
panther_lights/src/apa102.cpp Outdated Show resolved Hide resolved
Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
@KmakD KmakD requested a review from Kotochleb November 28, 2023 09:08
@Kotochleb Kotochleb merged commit 20d50c0 into ros2-devel Nov 28, 2023
@Kotochleb Kotochleb deleted the ros2-panther-lights branch November 28, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants