Manuall merge of ros2-prealpha to ros2-dev #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macstepien
suggested changes
Jan 18, 2024
pkowalsk1
reviewed
Jan 19, 2024
Comment on lines
+17
to
+19
| import textwrap | ||
|
|
||
| import click |
panther_gpiod/src/gpio_driver.cpp
Outdated
Comment on lines
112
to
118
| gpiod::line::value new_output_value; | ||
| if (!line_request_) { | ||
| new_output_value = gpio_info.init_value; | ||
| } else { | ||
| new_output_value = gpio_info.value; | ||
| } | ||
| settings.set_output_value(new_output_value); |
There was a problem hiding this comment.
Suggested change
| gpiod::line::value new_output_value; | |
| if (!line_request_) { | |
| new_output_value = gpio_info.init_value; | |
| } else { | |
| new_output_value = gpio_info.value; | |
| } | |
| settings.set_output_value(new_output_value); | |
| gpiod::line::value new_output_value = line_request_ ? gpio_info.value : gpio_info.init_value; | |
| settings.set_output_value(new_output_value); |
just a suggestion
panther_gpiod/src/gpio_driver.cpp
Outdated
Comment on lines
150
to
159
| bool GPIODriver::IsPinAvaible(const GPIOPin pin) const | ||
| { | ||
| for (auto & info : gpio_info_storage_) { | ||
| if (info.pin == pin) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| bool GPIODriver::IsPinAvaible(const GPIOPin pin) const | |
| { | |
| for (auto & info : gpio_info_storage_) { | |
| if (info.pin == pin) { | |
| return true; | |
| } | |
| } | |
| return false; | |
| } | |
| bool GPIODriver::IsPinAvaible(const GPIOPin pin) const | |
| { | |
| return std::any_of(gpio_info_storage_.begin(), gpio_info_storage_.end(), | |
| [&](const auto &info) { return info.pin == pin; }); | |
| } | |
It is considered more idiomatic in modern C++. Just another suggestion :p
With such changes, we still need to include .
There was a problem hiding this comment.
I'm sorry @KmakD. There is a typo in my comment caused by parsing <>. With such changes, we still need to include <algorithm>.
macstepien
approved these changes
Jan 19, 2024
pkowalsk1
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual merge of prealpha branch. Changes regarding
ros2_controlandpanther_hardware_interfaceswere omitted.