Ros2 - Add GPIO Tests #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KmakD
requested changes
Jan 24, 2024
There was a problem hiding this comment.
missing test for IsPinAvailable method
missing test for IsPinActive method
Dont we want to test CreateLineRequest? For exceptions like "No name defined for one of pins" etc.
Generally i think some private methods could be made protected and tested like HandleEdgeEvent
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
KmakD
requested changes
Feb 13, 2024
KmakD
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.