Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS 2 control liblely instalation #239

Merged
merged 8 commits into from
Mar 7, 2024

Conversation

KmakD
Copy link
Contributor

@KmakD KmakD commented Mar 5, 2024

This automates installation of liblely and libgiod libraries.
Super build was used to install required libraries only during initial build of the project

@KmakD KmakD requested a review from rafal-gorecki March 5, 2024 12:52
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me the version below is simpler

include(ExternalProject)

ExternalProject_Add(
  ep_liblely
  SOURCE_DIR ${CMAKE_CURRENT_BINARY_DIR}/ep_liblely/upstream
  INSTALL_DIR ${CMAKE_INSTALL_PREFIX}
  GIT_REPOSITORY https://gitlab.com/lely_industries/lely-core.git
  GIT_TAG v2.3.3
  PREFIX ${CMAKE_CURRENT_BINARY_DIR}/ep_liblely
  CONFIGURE_COMMAND autoreconf -i <SOURCE_DIR>
  COMMAND <SOURCE_DIR>/configure --prefix=<INSTALL_DIR> --disable-python
  --disable-tests --disable-static
  BUILD_COMMAND $(MAKE) -C <BINARY_DIR>
  INSTALL_COMMAND make install INSTALL_PREFIX=<INSTALL_DIR>
)

ExternalProject_Add(
  ep_panther_hardware_interfaces
  DEPENDS ep_liblely
  SOURCE_DIR ${PROJECT_SOURCE_DIR}
  CMAKE_ARGS -DUSE_SUPERBUILD=OFF
  INSTALL_COMMAND ""
  BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}
)

@KmakD
Copy link
Contributor Author

KmakD commented Mar 7, 2024

I left DEPENENCIES variable to keep more uniform structure of super build file where usually multiple dependencies are installed

@rafal-gorecki rafal-gorecki merged commit 54cfc05 into ros2-devel Mar 7, 2024
@rafal-gorecki rafal-gorecki deleted the ros2-control-liblely-instalation branch March 7, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants