Ros2 control add tests #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkowalsk1
reviewed
Mar 26, 2024
There was a problem hiding this comment.
There are several functionalities within panther_system and panther_system_ros_interface, including EStop manipulation and service wrappers, that remain untested. I suggest we create new tasks for the Beta release and aim to address them over the next month.
I've noted just a few minor points for the sake of principle, but overall, it looks good to me.
pkowalsk1
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for panther_system are not working and will not be fixed in this PR. Leave them here so we dont forget about this. Generally there is "promise already satisfy" error which suggest some race condition problem
Dependend PR: husarion/panther_msgs#19