Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test workflow #266

Merged
merged 13 commits into from
Apr 17, 2024
Merged

Add unit test workflow #266

merged 13 commits into from
Apr 17, 2024

Conversation

pawelirh
Copy link
Contributor

@pawelirh pawelirh commented Apr 11, 2024

Changes

  • Implemented testing workflow
  • Fully tested on the panteher_utils package ✅
  • Runner needs to be further improved to handle successfully all unit tests

❗ SQUASH COMMITS! ❗

@husarion husarion deleted a comment from github-actions bot Apr 11, 2024
Copy link
Contributor

Test coverage of modified packages:
lines......: 99.4% (328 of 330 lines)
functions..: 100.0% (130 of 130 functions)
branches...: 34.4% (400 of 1162 branches)

@delihus delihus self-requested a review April 17, 2024 06:13
Copy link
Contributor

@delihus delihus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the workflow in the readme file. Maybe add some nice workflow status badge?
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge

.github/workflows/run-unit-tests.yaml Show resolved Hide resolved
@pawelirh
Copy link
Contributor Author

pawelirh commented Apr 17, 2024

Regarding both comments

I'd wait with the readme update and badge until the tests are fully functional and pass to avoid always having a red badge.

As for the information that tests are run on hardware I'd see that info somewhere near/on the badge in readme. I'm not sure about the proposed filename since we don't need to distinguish between "hardware" and "non-hardware"(GitHub-hosted). What do you think, is it a good option in your opinion?

@delihus delihus self-requested a review April 17, 2024 07:04
@pawelirh pawelirh merged commit 8312b8f into ros2-devel Apr 17, 2024
1 check failed
@pawelirh pawelirh deleted the ros2-test-workflow-poc branch April 17, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants