Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed test with wrong imu sensor name #305

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

delihus
Copy link
Contributor

@delihus delihus commented May 15, 2024

After #304 checking wrong imu sensor name test is unnecessary.

Before:

[ RUN      ] TestPantherImuSensor.CheckSensorName
/home/deli/Documents/panther_dev/panther_ros/panther_hardware_interfaces/test/test_panther_imu.cpp:362: Failure
Expected: { imu_sensor_->CheckSensorName(); } throws an exception of type std::runtime_error.
  Actual: it throws nothing.
[  FAILED  ] TestPantherImuSensor.CheckSensorName (6 ms)

After:

[ RUN      ] TestPantherImuSensor.CheckSensorName
[       OK ] TestPantherImuSensor.CheckSensorName (6 ms)

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@delihus delihus requested review from pawelirh and rafal-gorecki May 15, 2024 06:33
@rafal-gorecki rafal-gorecki merged commit 779bc67 into ros2 May 15, 2024
@delihus delihus deleted the fix-imu-hwi-tests branch May 15, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants