ROS 2 revise and clear logs #320
Conversation
WalkthroughThis update introduces improved logging, error handling, and configuration across various modules in the Panther software. Key changes include adding Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@coderabbitai review |
Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Outside diff range and nitpick comments (4)
panther_hardware_interfaces/src/panther_system.cpp (4)
60-61: Refine error message for clarity in parameter reading exceptions.Consider rephrasing to "Failed to read parameters: " to directly indicate the operation that caused the error.
106-108: Consider adding retries or fallback mechanisms for motor controller activation.Given the critical nature of motor controller activation, implementing a retry mechanism or a fallback strategy could enhance system robustness.
195-195: Standardize error messages for consistency.Consider using a consistent prefix for all error messages related to exception handling, such as "Error during operation: ".
494-495: Improve clarity of driver state update errors.Refine the error message to specify which driver or component failed, providing more actionable information for troubleshooting.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (45)
- panther_battery/launch/battery.launch.py (1 hunks)
- panther_battery/src/battery_node.cpp (5 hunks)
- panther_battery/src/battery_publisher.cpp (2 hunks)
- panther_battery/src/roboteq_battery.cpp (1 hunks)
- panther_controller/launch/controller.launch.py (4 hunks)
- panther_description/launch/load_urdf.launch.py (1 hunks)
- panther_diagnostics/launch/system_status.launch.py (1 hunks)
- panther_diagnostics/src/system_status_node.cpp (5 hunks)
- panther_gpiod/src/gpio_driver.cpp (6 hunks)
- panther_hardware_interfaces/src/canopen_controller.cpp (5 hunks)
- panther_hardware_interfaces/src/gpio_controller.cpp (2 hunks)
- panther_hardware_interfaces/src/motors_controller.cpp (6 hunks)
- panther_hardware_interfaces/src/panther_imu.cpp (14 hunks)
- panther_hardware_interfaces/src/panther_system.cpp (20 hunks)
- panther_hardware_interfaces/src/panther_system_ros_interface.cpp (3 hunks)
- panther_hardware_interfaces/src/roboteq_driver.cpp (1 hunks)
- panther_hardware_interfaces/src/utils.cpp (1 hunks)
- panther_lights/launch/lights.launch.py (2 hunks)
- panther_lights/src/apa102.cpp (4 hunks)
- panther_lights/src/controller_node.cpp (9 hunks)
- panther_lights/src/driver_node.cpp (4 hunks)
- panther_lights/src/led_animations_queue.cpp (4 hunks)
- panther_lights/src/led_panel.cpp (1 hunks)
- panther_lights/src/led_segment.cpp (7 hunks)
- panther_localization/launch/ekf.launch.py (1 hunks)
- panther_manager/include/panther_manager/behavior_tree_utils.hpp (3 hunks)
- panther_manager/include/panther_manager/plugins/action/call_set_bool_service_node.hpp (1 hunks)
- panther_manager/include/panther_manager/plugins/action/call_set_led_animation_service_node.hpp (1 hunks)
- panther_manager/include/panther_manager/plugins/action/call_trigger_service_node.hpp (1 hunks)
- panther_manager/include/panther_manager/plugins/action/shutdown_hosts_from_file_node.hpp (1 hunks)
- panther_manager/include/panther_manager/plugins/action/shutdown_single_host_node.hpp (1 hunks)
- panther_manager/include/panther_manager/plugins/action/signal_shutdown_node.hpp (1 hunks)
- panther_manager/include/panther_manager/plugins/decorator/tick_after_timeout_node.hpp (1 hunks)
- panther_manager/include/panther_manager/plugins/shutdown_hosts_node.hpp (4 hunks)
- panther_manager/launch/manager_bt.launch.py (2 hunks)
- panther_manager/plugins/action/call_set_bool_service_node.cpp (2 hunks)
- panther_manager/plugins/action/call_set_led_animation_service_node.cpp (2 hunks)
- panther_manager/plugins/action/call_trigger_service_node.cpp (1 hunks)
- panther_manager/plugins/action/shutdown_hosts_from_file_node.cpp (2 hunks)
- panther_manager/plugins/action/shutdown_single_host_node.cpp (1 hunks)
- panther_manager/src/lights_manager_node.cpp (6 hunks)
- panther_manager/src/safety_manager_node.cpp (6 hunks)
- panther_utils/include/panther_utils/configure_rt.hpp (1 hunks)
- panther_utils/include/panther_utils/yaml_utils.hpp (1 hunks)
- panther_utils/panther_utils/welcomeMsg.py (1 hunks)
Files skipped from review due to trivial changes (14)
- panther_battery/src/roboteq_battery.cpp
- panther_hardware_interfaces/src/motors_controller.cpp
- panther_hardware_interfaces/src/panther_imu.cpp
- panther_hardware_interfaces/src/roboteq_driver.cpp
- panther_hardware_interfaces/src/utils.cpp
- panther_lights/src/apa102.cpp
- panther_lights/src/led_animations_queue.cpp
- panther_manager/include/panther_manager/plugins/action/call_set_bool_service_node.hpp
- panther_manager/include/panther_manager/plugins/action/call_set_led_animation_service_node.hpp
- panther_manager/include/panther_manager/plugins/action/call_trigger_service_node.hpp
- panther_manager/include/panther_manager/plugins/action/shutdown_single_host_node.hpp
- panther_manager/include/panther_manager/plugins/action/signal_shutdown_node.hpp
- panther_manager/include/panther_manager/plugins/shutdown_hosts_node.hpp
- panther_utils/include/panther_utils/configure_rt.hpp
Additional comments not posted (96)
panther_manager/include/panther_manager/plugins/decorator/tick_after_timeout_node.hpp (1)
25-25: The import ofbehavior_tree_utils.hppis appropriate for utility functions in behavior trees.panther_diagnostics/launch/system_status.launch.py (1)
37-37: Addingemulate_tty=Trueenhances console output readability, aligning with the PR's objectives to improve logging.panther_battery/launch/battery.launch.py (1)
39-39: Consistent with other launch files, addingemulate_tty=Trueimproves the logging experience.panther_manager/include/panther_manager/plugins/action/shutdown_hosts_from_file_node.hpp (1)
25-25: The imports are appropriate for the functionality of shutting down hosts from a file, enhancing modularity and reusability.panther_manager/plugins/action/call_trigger_service_node.cpp (1)
28-29: The added logging statements provide detailed feedback on the service call status, enhancing error tracking and operational transparency.Also applies to: 33-34
panther_manager/plugins/action/call_set_bool_service_node.cpp (1)
23-23: The added logging statements provide detailed feedback on the service call status, enhancing error tracking and operational transparency.Also applies to: 33-34, 38-39
panther_lights/src/led_panel.cpp (1)
34-34: Improved error handling with detailed messages enhances clarity and debuggability.Also applies to: 37-39, 42-47
panther_utils/include/panther_utils/yaml_utils.hpp (1)
38-38: Enhanced error messages for missing keys and conversion failures improve usability.Also applies to: 44-44
panther_utils/panther_utils/welcomeMsg.py (1)
55-61: Added fields to the welcome message enhance the comprehensiveness of system information provided.panther_manager/plugins/action/call_set_led_animation_service_node.cpp (1)
28-28: Enhanced error and success logging in service interaction methods improves clarity and debuggability.Also applies to: 35-35, 40-41, 53-54, 58-59
panther_localization/launch/ekf.launch.py (1)
65-65: Addedemulate_tty=Trueto the node declaration likely improves logging output in terminal environments.panther_manager/plugins/action/shutdown_single_host_node.cpp (1)
33-33: Enhanced error logging for input parameters in theUpdateHostsmethod improves clarity and debuggability.Also applies to: 39-39, 45-45, 51-51, 57-57, 63-64
panther_lights/launch/lights.launch.py (2)
59-59: The addition ofemulate_tty=Trueensures proper formatting of log outputs, aligning with the PR's objectives to enhance logging mechanisms.
72-72: The addition ofemulate_tty=Truefor thelights_controller_nodeis a good practice for ensuring readable log outputs.panther_manager/plugins/action/shutdown_hosts_from_file_node.cpp (3)
38-39: Proper error logging for missing or emptyshutdown_hosts_fileenhances error traceability.
47-48: Logging the specific YAML file loading error aids in quicker troubleshooting of configuration issues.
73-73: Logging runtime errors during host processing is essential for maintaining robust error handling.panther_manager/include/panther_manager/behavior_tree_utils.hpp (3)
41-41: The function for registering behavior trees enhances modularity by allowing dynamic loading of custom BT nodes.
64-64: Extending behavior tree registration to include ROS nodes supports better integration with ROS ecosystems.
89-89: Standardizing logger prefixes using the BT node name enhances consistency in log outputs across different modules.panther_manager/launch/manager_bt.launch.py (2)
83-83: The addition ofemulate_tty=Trueensures proper formatting of log outputs, aligning with the PR's objectives to enhance logging mechanisms.
98-98: The addition ofemulate_tty=Truefor thesafety_manager_nodeis a good practice for ensuring readable log outputs.panther_battery/src/battery_publisher.cpp (2)
53-54: Throttling error logs for battery data reading exceptions is a good practice to avoid log spam while ensuring important information is logged.
92-92: Throttling informational logs about battery charging status is appropriate, as these events are infrequent and do not require constant logging.Also applies to: 98-98
panther_lights/src/led_segment.cpp (7)
39-39: Clear error message for missing '-' in LED range expression aids in debugging and configuration validation.
50-50: Proper error handling for string to integer conversion issues prevents further errors and enhances robustness.
103-103: Error handling for undefined segment animations ensures that all segments are properly configured before operation.
127-127: Proper error handling for undefined animations during frame requests prevents runtime errors and ensures smooth operation.
140-140: Error handling for undefined animations when querying progress ensures that the animation state is always known, enhancing reliability.
149-149: Error handling for undefined animations during reset operations ensures that operations on animations are valid and prevents runtime errors.
159-159: Error handling for undefined animations when querying brightness ensures that animation properties are always accessible, enhancing usability.panther_diagnostics/src/system_status_node.cpp (4)
36-37: Added initialization log message.This log message provides clarity on the node's initialization process, which is beneficial for debugging and monitoring.
51-51: Added log message confirming successful initialization.This log message is useful for confirming that the node has been initialized successfully, aiding in troubleshooting and system checks.
96-97: Improved error handling for CPU temperature reading.The updated error message provides more detailed information about exceptions, which enhances the ability to diagnose issues related to CPU temperature readings.
Line range hint
136-159: Refined system diagnostic messages and error handling.The changes enhance the diagnostic capabilities of the system by providing more specific messages based on the system's status and thresholds. This is crucial for maintaining system health and responsiveness.
panther_hardware_interfaces/src/canopen_controller.cpp (5)
50-50: Improved exception handling during RT configuration.The detailed error message and the note about potential performance impact provide valuable information for debugging and operational awareness.
59-59: Enhanced error handling during CAN initialization.The updated error message provides clearer information on the nature of the issue, which is crucial for troubleshooting CAN communication problems.
71-71: Updated error handling in the communication loop.The explicit error message helps in identifying issues during the loop run, which is critical for maintaining stable and reliable CAN communication.
81-81: Added exception for failed CAN communication initialization.This exception handling is essential for ensuring that the system is aware of unsuccessful initializations, which can prevent further errors in the system's operation.
186-186: Standardized error message for driver booting issues.The consistent and clear error messaging helps in quickly identifying and resolving issues related to driver booting, enhancing system reliability.
panther_battery/src/battery_node.cpp (8)
41-42: Added log message for node construction.This log message provides immediate feedback on the construction process of the node, which is useful for debugging and system monitoring.
53-53: Added log message confirming successful node construction.This log message confirms that the node has been constructed successfully, which is beneficial for system checks and initial diagnostics.
58-59: Added initialization log message.This log message provides clarity on the node's initialization process, which is beneficial for debugging and monitoring.
66-69: Improved error handling during ADC initialization.The detailed error message and fallback mechanism enhance robustness by providing alternative options if the initial method fails.
74-74: Added log message confirming successful initialization.This log message is useful for confirming that the node has been initialized successfully, aiding in troubleshooting and system checks.
79-79: Added debug log for ADC battery initialization.This debug log provides detailed insights during the ADC battery initialization process, which is helpful for fine-tuning and troubleshooting.
127-127: Added informational log about battery driver using ADC data.This log message informs about the successful setup of the battery driver with ADC data, enhancing transparency and operational awareness.
132-132: Added debug log for Roboteq battery initialization.This debug log provides detailed insights during the Roboteq battery initialization process, which is helpful for fine-tuning and troubleshooting.
panther_lights/src/driver_node.cpp (4)
48-49: Added log message for node construction.This log message provides immediate feedback on the construction process of the node, which is useful for debugging and system monitoring.
59-59: Added log message confirming successful node construction.This log message confirms that the node has been constructed successfully, which is beneficial for system checks and initial diagnostics.
64-65: Added initialization log message.This log message provides clarity on the node's initialization process, which is beneficial for debugging and monitoring.
96-96: Added log message confirming successful initialization.This log message is useful for confirming that the node has been initialized successfully, aiding in troubleshooting and system checks.
panther_description/launch/load_urdf.launch.py (2)
178-178: Addedemulate_tty=Truetorobot_state_publishernode.This parameter ensures that the output from the node is properly formatted, which can be crucial for debugging and monitoring in environments where the node's output is logged or monitored.
185-185: Addedemulate_tty=Truetojoint_state_publishernode.This parameter ensures that the output from the node is properly formatted, which can be crucial for debugging and monitoring in environments where the node's output is logged or monitored.
panther_hardware_interfaces/src/gpio_controller.cpp (4)
150-150: Standardized error message for E-stop reset failure.The clear and consistent error message helps in quickly identifying issues related to E-stop reset failures, which is crucial for safety and troubleshooting.
236-236: Standardized error message for motor power check.The clear and consistent error message helps in quickly identifying issues related to motor power, which is crucial for operational safety and troubleshooting.
244-244: Standardized error message for motor power enable check.The clear and consistent error message helps in quickly identifying issues related to motor power enablement, which is crucial for operational safety and troubleshooting.
252-252: Standardized error messages for unsupported functionalities.The clear and consistent error messages help in quickly identifying unsupported functionalities, which is crucial for operational clarity and preventing misuse of the system.
Also applies to: 257-257, 262-262, 267-267
panther_gpiod/src/gpio_driver.cpp (5)
41-41: Improved error message for empty GPIO vector enhances clarity.
182-182: Updated error message for failed GPIO state change improves clarity.
192-192: Updated exception handling message improves error clarity and troubleshooting.
218-218: Updated timeout error message inGPIOMonitorOnmethod enhances clarity.
254-254: Updated exception handling message for edge events improves error clarity.panther_manager/src/lights_manager_node.cpp (4)
40-40: Added logging messages in constructor and post-construction enhance traceability.Also applies to: 53-53
58-58: Added logging messages inInitializemethod enhance traceability of initialization steps.Also applies to: 78-78
112-112: Added logging message for behavior tree registration enhances operational transparency.
160-160: Added logging message for blackboard creation enhances operational transparency.panther_hardware_interfaces/src/panther_system_ros_interface.cpp (2)
78-78: Added logging messages in constructor and post-construction enhance traceability.Also applies to: 102-102
56-56: Added logging message for exception handling in service callback enhances operational transparency.panther_controller/launch/controller.launch.py (2)
202-202: Addedemulate_tty=Trueparameter to node declarations enhances terminal logging output.Also applies to: 229-229, 245-245, 269-269
210-210: Added arguments to suppress stdout logs inrobot_state_pub_nodereduces noise, enhancing focus on relevant logs.panther_manager/src/safety_manager_node.cpp (7)
42-42: Added a log message for node construction.This log message is useful for debugging the initialization process of the node.
69-69: Added a log message confirming successful node construction.This log message provides clear feedback that the node has been constructed successfully, which is beneficial for system monitoring.
74-74: Added a log message for the start of initialization.This log message is helpful for tracking the initialization sequence of the node.
110-110: Added a log message confirming successful initialization.This log message confirms that the initialization process has completed successfully, aiding in troubleshooting and system checks.
146-147: Added a log message confirming the successful initialization of the LED segments map.This log message is useful for verifying that the LED segments map has been set up correctly.
181-181: Added a log message indicating that the blackboard has been created.This log message helps in confirming the successful setup of the initial blackboard, which is crucial for the behavior tree's operation.
265-265: Added a throttled log message for system readiness.This log message is beneficial for indicating the waiting state for system messages without flooding the log, thanks to the throttling.
panther_lights/src/controller_node.cpp (13)
46-46: Added a log message for the start of the controller node initialization.This log message is useful for tracking the beginning of the initialization process.
80-80: Added a log message confirming successful initialization of the controller node.This log message provides clear feedback that the controller node has been initialized successfully, which is beneficial for system monitoring.
85-85: Added a debug log message for the initialization of LED panels.This debug log message is helpful for developers to ensure that the LED panels are being initialized correctly.
106-107: Added a debug log message for each initialized LED panel.These detailed debug messages provide valuable information about each panel's initialization, which can assist in troubleshooting.
114-114: Added a debug log message for the start of LED segments initialization.This log message is useful for developers to track the initialization process of LED segments.
133-133: Added a debug log message for each initialized LED segment.These detailed debug messages provide valuable information about each segment's initialization, which can assist in troubleshooting.
139-139: Added a debug log message for the start of LED segments map initialization.This log message is useful for tracking the setup process of the LED segments map.
147-147: Added a debug log message confirming the successful initialization of the LED segments map.This log message confirms that the LED segments map has been set up correctly, aiding in system configuration verification.
152-152: Added a debug log message for the start of loading default animations.This log message is useful for tracking the loading process of default animations.
158-158: Added an informational log message confirming that default animations have been loaded.This log message provides clear feedback that the default animations have been loaded successfully, which is beneficial for system checks.
163-163: Added a debug log message for the start of loading user animations.This log message is useful for tracking the loading process of user-defined animations.
193-193: Added an informational log message confirming that user animations have been loaded.This log message provides clear feedback that the user animations have been loaded successfully, which is beneficial for system checks.
286-286: Added a throttled log message for waiting for an animation.This log message is beneficial for indicating the waiting state for an animation without flooding the log, thanks to the throttling.
panther_hardware_interfaces/src/panther_system.cpp (5)
433-433: Confirm successful configuration of GPIO controller.This log statement effectively confirms the successful configuration of the GPIO controller.
469-469: Successfully configured E-Stop.The log statement confirms the successful configuration of E-Stop, enhancing operational transparency.
531-535: Effectively manage motor state data timeouts.Throttling and specific logging of motor state data timeouts are well-handled, aiding in pinpointing issues during operations.
598-602: Handle driver state timeouts effectively.The throttled warning for driver state timeouts is appropriately implemented, ensuring that the system remains responsive and manageable during such events.
48-48: Ensure consistent error handling across all initialization steps.Verification successful
Ensure consistent error handling across all initialization steps.
The search results show multiple try-catch blocks within the
panther_system.cppfile, each handling exceptions and logging errors. The error handling appears consistent, with exceptions being logged and appropriate actions taken (e.g., returningCallbackReturn::ERRORor updating error filters).
Initialization Steps:
CheckJointSize(),SortAndCheckJointNames(),SetInitialValues(),CheckInterfaces()ReadPantherVersion(),ReadDrivetrainSettings(),ReadCANopenSettings(),ReadInitializationActivationAttempts(),ReadParametersAndCreateRoboteqErrorFilter(),ReadDriverStatesUpdateFrequency()ConfigureGPIOController(),ConfigureMotorsController(),ConfigureEStop()e_stop_->TriggerEStop()motors_controller_->UpdateMotorsStates(),UpdateHwStates(),UpdateMotorsStatesDataTimedOut()motors_controller_->UpdateDriversState(),UpdateDriverStateMsg(),UpdateFlagErrors(),UpdateDriverStateDataTimedOut()Error Handling:
- Logging exceptions with
RCLCPP_ERROR_STREAMorRCLCPP_WARN_STREAM- Returning
CallbackReturn::ERRORor updating error filtersThe error handling is consistent across all initialization steps, ensuring that exceptions are properly logged and handled.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all initialization steps in `on_init` method have consistent error handling. # Test: Search for error handling in `on_init` method. Expect: Consistent error handling across all steps. ast-grep --lang cpp --pattern $'CallbackReturn PantherSystem::on_init($_) { $$$ try { $$$ } catch (const std::runtime_error & e) { RCLCPP_ERROR_STREAM(logger_, "An exception occurred while initializing: " << e.what()); return CallbackReturn::ERROR; } $$$ }'Length of output: 280
Script:
#!/bin/bash # Description: Verify that all initialization steps in `on_init` method have consistent error handling. # Test: Search for the `on_init` method and list all try-catch blocks within it. ast-grep --lang cpp --pattern $'CallbackReturn PantherSystem::on_init($_) { $$$ try { $$$ } catch ($_ & e) { $$$ } $$$ }' panther_hardware_interfaces/src/panther_system.cppLength of output: 191
Script:
#!/bin/bash # Description: Verify that all initialization steps in `on_init` method have consistent error handling. # Step 1: Search for the `on_init` method definition. ast-grep --lang cpp --pattern 'CallbackReturn PantherSystem::on_init($_)' panther_hardware_interfaces/src/panther_system.cpp # Step 2: Search for all try-catch blocks within the `panther_system.cpp` file. ast-grep --lang cpp --pattern 'try { $$$ } catch ($_ & e) { $$$ }' panther_hardware_interfaces/src/panther_system.cppLength of output: 246
Script:
#!/bin/bash # Description: Verify that all initialization steps in `panther_system.cpp` have consistent error handling. # Step 1: Search for all method definitions in the `panther_system.cpp` file. ast-grep --lang cpp --pattern '$_ $_::$_($_) { $$$ }' panther_hardware_interfaces/src/panther_system.cpp # Step 2: Search for all try-catch blocks within the `panther_system.cpp` file. ast-grep --lang cpp --pattern 'try { $$$ } catch ($_ & e) { $$$ }' panther_hardware_interfaces/src/panther_system.cppLength of output: 226
Script:
#!/bin/bash # Description: Verify that all initialization steps in `panther_system.cpp` have consistent error handling. # Step 1: Search for all method definitions in the `panther_system.cpp` file. rg --pcre2 --multiline --multiline-dotall '^[a-zA-Z_][a-zA-Z0-9_]* [a-zA-Z_][a-zA-Z0-9_]*::[a-zA-Z_][a-zA-Z0-9_]*\([^)]*\) \{[^}]*\}' panther_hardware_interfaces/src/panther_system.cpp # Step 2: Search for all try-catch blocks within the `panther_system.cpp` file. rg --pcre2 --multiline --multiline-dotall 'try \{[^}]*\} catch \([^)]*\) \{[^}]*\}' panther_hardware_interfaces/src/panther_system.cppLength of output: 2631
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- panther_gazebo/launch/simulate_multiple_robots.launch.py (1 hunks)
- panther_gazebo/launch/simulate_robot.launch.py (1 hunks)
- panther_gazebo/launch/spawn_robot.launch.py (1 hunks)
Files skipped from review due to trivial changes (1)
- panther_gazebo/launch/simulate_robot.launch.py
Additional comments not posted (2)
panther_gazebo/launch/spawn_robot.launch.py (1)
111-111: Approved the addition ofemulate_tty=Trueto enhance terminal output readability during simulations.panther_gazebo/launch/simulate_multiple_robots.launch.py (1)
100-100: Approved the conditional addition ofemulate_tty=Truefor thestatic_transform_publishernode to enhance terminal output readability whenadd_world_transformis enabled.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- panther_hardware_interfaces/src/panther_system.cpp (20 hunks)
Files skipped from review as they are similar to previous changes (1)
- panther_hardware_interfaces/src/panther_system.cpp
panther_manager/include/panther_manager/plugins/action/call_set_bool_service_node.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- panther_battery/src/battery_node.cpp (5 hunks)
- panther_hardware_interfaces/src/panther_system.cpp (20 hunks)
- panther_manager/plugins/action/call_set_bool_service_node.cpp (2 hunks)
- panther_manager/plugins/action/call_set_led_animation_service_node.cpp (2 hunks)
- panther_manager/plugins/action/call_trigger_service_node.cpp (2 hunks)
- panther_manager/plugins/action/shutdown_hosts_from_file_node.cpp (3 hunks)
- panther_manager/plugins/action/shutdown_single_host_node.cpp (2 hunks)
- panther_manager/plugins/decorator/tick_after_timeout_node.cpp (1 hunks)
- panther_manager/src/lights_manager_node.cpp (6 hunks)
Files skipped from review due to trivial changes (2)
- panther_manager/plugins/action/call_set_bool_service_node.cpp
- panther_manager/plugins/decorator/tick_after_timeout_node.cpp
Files skipped from review as they are similar to previous changes (7)
- panther_battery/src/battery_node.cpp
- panther_hardware_interfaces/src/panther_system.cpp
- panther_manager/plugins/action/call_set_led_animation_service_node.cpp
- panther_manager/plugins/action/call_trigger_service_node.cpp
- panther_manager/plugins/action/shutdown_hosts_from_file_node.cpp
- panther_manager/plugins/action/shutdown_single_host_node.cpp
- panther_manager/src/lights_manager_node.cpp
Summary by CodeRabbit
New Features
emulate_tty=Trueparameter to various node configurations for improved TTY emulation.Bug Fixes
Refactor