-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing module configuration #389
Conversation
WalkthroughThe changes in the Panther Manager project's Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- panther_manager/CMakeLists.txt (1 hunks)
Additional comments not posted (2)
panther_manager/CMakeLists.txt (2)
99-99
: LGTM: Addition ofPkgConfig
is appropriate.The inclusion of
find_package(PkgConfig REQUIRED)
is a good practice for managing library dependencies and ensures thatPkgConfig
is available during the build process.
100-100
: LGTM: Addition oflibssh
check is necessary.The inclusion of
pkg_check_modules(LIBSSH REQUIRED libssh)
ensures that thelibssh
library is available, which is crucial for SSH functionalities in the project.
Description
On RPI panther_manager failed on build
Modifications
Summary by CodeRabbit
PkgConfig
andlibssh
libraries are present during the build process, improving reliability and functionality.