Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespaces #81

Merged
merged 35 commits into from
Dec 1, 2023
Merged

Add namespaces #81

merged 35 commits into from
Dec 1, 2023

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Nov 14, 2023

Added namespace support for the rosbot_ros. The namespaces are not implemented for the gazebo simulation.
bump::patch

This PR depends on this:
(It is not necessary) husarion/rosbot_hardware_interfaces#9
husarion/husarion_controllers#3

After this changes we have to change the .repos files

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@delihus delihus marked this pull request as draft November 14, 2023 11:01
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this with your code: #82

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
…ken imu

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@delihus delihus marked this pull request as ready for review November 29, 2023 09:17
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@delihus
Copy link
Contributor Author

delihus commented Nov 29, 2023

I have changed ekf test from tf listener to odom topic reader because I could not remap tf topics for TfListener

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@rafal-gorecki
Copy link
Contributor

rafal-gorecki commented Nov 30, 2023

I'd also change from bump::minor to bump::patch (it is still a lot of to do)

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
delihus and others added 2 commits November 30, 2023 13:48
Co-authored-by: rafal-gorecki <126687345+rafal-gorecki@users.noreply.github.com>
@rafal-gorecki rafal-gorecki merged commit 5762b53 into humble Dec 1, 2023
3 checks passed
@rafal-gorecki rafal-gorecki deleted the add-namespaces branch December 1, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants