Feat patch idna security issue #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain version to 1.81.0
…e discovered by dependabot
|
Rust unit test passed. I think we can go to merge this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependabot issue:
idnaaccepts Punycode labels that do not produce any non-ASCII when decodedidnaused byurlthat is used byoctocrabandsqlite.To mitigate this issue, I tried manually updating the
ideaversion to1.0.0by using thecargo add idna@1.0.0command from the local development device. This doesn't work, of course. The second try is to update all crates withcargo update,but I make sure theideawas updated by running the dry run versioncargo update—-dry-run.After confirming the
idnawill be bumped to1.0.3I ran the update crates command and tested the new update. Turns out there is an error in the coreErrorcrate that is tracked in here. The fix was introduced to rust toolchain1.81.0. So I upgrade Rust version, dockerfile, and github action workflows to follow the requirements. I don't think it counts as a major update in semver as we didn't introduce breaking changes (will update this PR later).