Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resize to occur if style or className have changed #459

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Allow resize to occur if style or className have changed #459

merged 2 commits into from
Oct 29, 2021

Conversation

mobeigi
Copy link
Collaborator

@mobeigi mobeigi commented Oct 26, 2021

Fixes: #446

The pickKeys line returns early even if the style and className have changed so the check below it is unreachable code.

So solve this we inverse the check and do a this.updateEChartsOption() if the pickKeys props have changed.
Then we also do the check for style and className updates before resizing.

src/core.tsx Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.97% when pulling 843bf39 on mobeigi:fix-style-classname-bug into 7d20c9a on hustcc:master.

@mobeigi
Copy link
Collaborator Author

mobeigi commented Oct 28, 2021

Hi @hustcc , thanks for reviewing the outstanding PRs. 👍

I am hoping we can also merge in this PR fix and release new npm version 3.0.2

@hustcc hustcc merged commit 7be262c into hustcc:master Oct 29, 2021
@hustcc
Copy link
Owner

hustcc commented Oct 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Echart is not refreshed when only style and className change.
3 participants