Add reset function #123
Open
Add reset function #123
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Aug 12, 2024
| @@ -1446,6 +1447,21 @@ export default class CanvasRenderingContext2D { | |||
| this._path.push(event); | |||
| } | |||
|
|
|||
| reset() { | |||
| if (arguments.length > 0) { | |||
| throw new TypeError( | |||
There was a problem hiding this comment.
Is the information thrown standardized?
There was a problem hiding this comment.
I'm not sure what you mean by this. I tried to make it match the information used in the rect function.
| }); | ||
|
|
||
| it('should throw if any parameters are given', () => { | ||
| expect(() => ctx.rect(1)).toThrow(TypeError); |
There was a problem hiding this comment.
So, something like expect(() => ctx.reset(1)).toThrow(/Failed to execute 'reset' on/);?
|
I'm not sure if there is more you need me to do, but if so, please let me know. I am eager to get this merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use this library, but my project uses the reset function pretty heavily which is currently missing from this mock. This PR adds that function to the mock.