Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update system caption button colors #562

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

United600
Copy link
Collaborator

Changes the caption button colors according to the design specifications. Uses subtle brushes for the hover and pressed background color. Also fixes the caption buttons when in light mode with the "Show accent color on title bars and windows borders" setting enabled

Old New
Shows the hover color of the current minimize caption button Shows the hover color of the new minimize caption button

Task list

  • Fix the transition between video and audio content in light mode
  • Trigger the color change with the app theme setting

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Feb 10, 2025
@huynhsontung
Copy link
Owner

Is this PR ready to merge, btw? I see there are incomplete tasks on the task list.

@United600
Copy link
Collaborator Author

Is this PR ready to merge, btw? I see there are incomplete tasks on the task list.

Not really. AFAIK it's not regressing anything, but there's room for improvement. Maybe moving the logic to App.xaml.cs to consolidate both the main page and player page implementation? Do we need some sort of a theme helper?
I also believe addressing the in-app theme change is imperative.

@United600 United600 marked this pull request as draft February 24, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants