Client.write method breaking changes 2.0.0
#1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
dependencies
Codecov Report
@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
+ Coverage 86.99% 87.09% +0.09%
==========================================
Files 64 64
Lines 3115 3146 +31
==========================================
+ Hits 2710 2740 +30
- Misses 405 406 +1
|
briantist
changed the title
Client.write method breaking changes 2.0.0
|
@M0NsTeRRR in case you're interested in reviewing |
M0NsTeRRR
reviewed
Oct 15, 2023
M0NsTeRRR
reviewed
Oct 15, 2023
| value = dict.pop(member) | ||
| except KeyError: | ||
| if posvalue is not _sentinel: | ||
| return posvalue |
There was a problem hiding this comment.
Maybe its better to have only one return and do value = posvalue and for the next elif value = default for readability ?
There was a problem hiding this comment.
Maybe personal preference but I prefer the return for readability, otherwise I have to follow the rest of the flow to see where the value gets used again and/or returned.
|
LGTM (haven't time to test it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
Client.writemethod #1034 (v2 changes)Resolves #1079
This also adds a bunch of type hints and such, and some additional test coverage.