Update the event handler to avoid sending the event to the createEditor function #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2024 14:11
…ction and update the event listener to avoid sending the event to the CKEditor createEditor function.
|
@frague59 do we need the first commit? having a commit which reverts the changes from the previous commit seems unnecessary, why not just have one commit with the changes we need ? :) |
|
No, we do not need it. I don't know how to remove it |
|
As this PR rollbacks the first commit, it can be merged, no ? |
It just adds an unnecessary commit to the history, so it's nicer if we remove it. I think @hvlads can edit the PR and remove it maybe. |
|
Fix #253 |
|
Hi @frague59 , Could you please create a new pull request with changes only in the specific line that resolves your issue? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with django-content-editor, fix a bug in the
formset:addedprocess in CKEditor apps.jsThe PR also rollback previous PR attempt.