Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement types of Python #66

Closed
hwakabh opened this issue Jan 19, 2024 · 0 comments · Fixed by #77
Closed

Implement types of Python #66

hwakabh opened this issue Jan 19, 2024 · 0 comments · Fixed by #77
Assignees
@hwakabh
Labels
chore Changes not related to application logics enhancement New feature or request

Comments

@hwakabh
Copy link
Owner

hwakabh commented Jan 19, 2024 •
edited
Loading

AsIs

Though we have used FastAPI, based on Pydantic V2, almost all of current Python code base does not mark up with its types.
Without pydantic we can not leverage its validation for API field, so this is type-unsafed and makes API work as unexpected way.

ToDo

Implemented schemas to current code basis with Pydantic, mainly to routers.py and cruds.py

(Optional) Acceptance Criteria

  • Application will be started up locally without any error locally
  • pytest results will not have any regression
@hwakabh hwakabh added enhancement New feature or request chore Changes not related to application logics labels Jan 19, 2024
@hwakabh hwakabh self-assigned this Jan 19, 2024
This was referenced Jan 20, 2024
Merged
Merged
hwakabh added a commit that referenced this issue Jan 22, 2024
@hwakabh
feat: added schemas for v0 API: #66.
fefedc3
@github-actions github-actions bot mentioned this issue Jan 22, 2024
Merged
hwakabh added a commit that referenced this issue Jan 23, 2024
@hwakabh
chore(types): updated schemas for database entities: #66
3e7e362
@hwakabh hwakabh mentioned this issue Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwakabh hwakabh

Labels
chore Changes not related to application logics enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: implemented schemas and typehints hwakabh/random-travelers
1 participant
@hwakabh