Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database dependencies #74

Closed
hwakabh opened this issue Jan 22, 2024 · 0 comments · Fixed by #76
Closed

Remove database dependencies #74

hwakabh opened this issue Jan 22, 2024 · 0 comments · Fixed by #76
Assignees
Labels
chore Changes not related to application logics deps Issue or PR that update a dependency file enhancement New feature or request

Comments

@hwakabh
Copy link
Owner

hwakabh commented Jan 22, 2024

AsIs

With current code basis, the transaction with MySQL will be used mysql-connector-python directly, without using ORM like SQLAlchemy.
As commented, with SQLAlchemy we can integrate them with its dialects, and draft base class have been implemented in #72.

ToDo

  • Complete implementations of Airport model with replacing table schema in insert.sql with ORM syntax
  • Replace SQL for database with SQLAlchemy Python methods

(Optional) Acceptance Criteria

  • Tests/Build pipeline will be passed
  • Application runs without any error locally
@hwakabh hwakabh added enhancement New feature or request chore Changes not related to application logics deps Issue or PR that update a dependency file labels Jan 22, 2024
@hwakabh hwakabh self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes not related to application logics deps Issue or PR that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant