Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow binary data to be used for passwords #174

Closed
brotskydotcom opened this issue Jun 20, 2024 · 0 comments
Closed

Allow binary data to be used for passwords #174

brotskydotcom opened this issue Jun 20, 2024 · 0 comments
Labels
enhancement help wanted

Comments

@brotskydotcom
Copy link
Collaborator

Since all of the underlying platform stores support storing Vec data in credentials, it seems wasteful to force clients to encode such data as UTF-8 strings. Please add generic APIs for get_password_blob and set_password_blob that allow storing and retrieving Vec<u8> data in the most efficient way for each store.
@brotskydotcom brotskydotcom mentioned this issue Jul 6, 2024
Closed
brotskydotcom added a commit to brotskydotcom/keyring-rs that referenced this issue Jul 7, 2024
@brotskydotcom
Make API changes to support binary secrets.
760c4c5 
1. Add set_secret and get_secret entries to credentials and keystores and tests.
2. Rename delete_password to delete_credential everywhere.

This fixes hwchen#174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brotskydotcom